multicluster-observability-operator
multicluster-observability-operator copied to clipboard
Add a new CNV VMs resources utilization dashboard
This PR adds a new dashboard that reports the VMs resources utilization.
Signed-off-by: Shirly Radco [email protected]
@moadz Hi, Please review this PR. I see it is failing on missing metrics, but all of them were added in the metrics_allowlist.yaml.
/retest
@moadz Hi, Please review this PR. I see it is failing on missing metrics, but all of them were added in the metrics_allowlist.yaml.
Hi, following PR: https://github.com/stolostron/multicluster-observability-operator/pull/1726 we also need to add new metrics to the scrape-config (found in the same folder as the dashboard, here for virt: https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/virtualization/scrape-config.yaml).
Please add the new collected metric there and it should make the test pass.
Hi @moadz , The PR is ready for review.
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: moadz, sradco
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [moadz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sradco just need to pass CI by following Jacobs comment above + rebasing.
+1 @moadz I added the metrics to both locations
New changes are detected. LGTM label has been removed.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
/retest
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@sradco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/test-e2e | 2e530bbdc4eb5fa9376527335b31b1c3c329c6b4 | link | true | /test test-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.