multicluster-observability-operator icon indicating copy to clipboard operation
multicluster-observability-operator copied to clipboard

Add a new CNV VMs resources utilization dashboard

Open sradco opened this issue 9 months ago • 13 comments

This PR adds a new dashboard that reports the VMs resources utilization.

Signed-off-by: Shirly Radco [email protected]

sradco avatar Feb 24 '25 20:02 sradco

@moadz Hi, Please review this PR. I see it is failing on missing metrics, but all of them were added in the metrics_allowlist.yaml.

sradco avatar Feb 25 '25 07:02 sradco

/retest

jacobbaungard avatar Feb 25 '25 13:02 jacobbaungard

@moadz Hi, Please review this PR. I see it is failing on missing metrics, but all of them were added in the metrics_allowlist.yaml.

Hi, following PR: https://github.com/stolostron/multicluster-observability-operator/pull/1726 we also need to add new metrics to the scrape-config (found in the same folder as the dashboard, here for virt: https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/virtualization/scrape-config.yaml).

Please add the new collected metric there and it should make the test pass.

jacobbaungard avatar Feb 25 '25 13:02 jacobbaungard

Hi @moadz , The PR is ready for review.

sradco avatar Mar 18 '25 09:03 sradco

/retest

sradco avatar Mar 18 '25 09:03 sradco

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadz, sradco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 18 '25 09:03 openshift-ci[bot]

@sradco just need to pass CI by following Jacobs comment above + rebasing.

moadz avatar Mar 18 '25 09:03 moadz

+1 @moadz I added the metrics to both locations

sradco avatar Mar 18 '25 09:03 sradco

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Mar 24 '25 08:03 openshift-ci[bot]

/retest

jacobbaungard avatar Mar 31 '25 12:03 jacobbaungard

@sradco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e 2e530bbdc4eb5fa9376527335b31b1c3c329c6b4 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 16 '25 15:05 openshift-ci[bot]