multicluster-global-hub
multicluster-global-hub copied to clipboard
stolostron
:sparkles: enable the global hub addon in hosted mode - renaming
Summary
Related issue(s)
Reference: https://github.com/stolostron/multicluster-global-hub/pull/1686
Tests
- [x] Unit/function tests have been added and incorporated into
make unit-tests. - [x] Integration tests have been added and incorporated into
make integration-test. - [ ] E2E tests have been added and incorporated into
make e2e-test-all. - [ ] List other manual tests you have done.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: yanmxa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [yanmxa]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Quality Gate failed
Failed conditions
69.3% Coverage on New Code (required ≥ 70%)
See analysis details on SonarQube Cloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yanmxa: Overrode contexts on behalf of yanmxa: ci/prow/sonarcloud
In response to this:
/override ci/prow/sonarcloud
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@yanmxa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/test-e2e | ddf6af25cb2df153e8f3bbc71ec25e58f8faa8e7 | link | true | /test test-e2e |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
