multicluster-global-hub icon indicating copy to clipboard operation
multicluster-global-hub copied to clipboard

:sparkles :bug: Add Relationship and correct the update operations

Open clyang82 opened this issue 1 year ago • 3 comments

Summary

  1. distinguish create and update inspired from https://github.com/stolostron/multicluster-global-hub/pull/1154 Thanks @yanmxa
  2. Correct the usage for update and delete
  3. Add labels to the request metadata
  4. Add relationship for the policy to show the status

Related issue(s)

Fixes #https://issues.redhat.com/browse/ACM-14812

Tests

  • [ ] Unit/function tests have been added and incorporated into make unit-tests.
  • [ ] Integration tests have been added and incorporated into make integration-test.
  • [ ] E2E tests have been added and incorporated into make e2e-test-all.
  • [ ] List other manual tests you have done.

clyang82 avatar Oct 11 '24 08:10 clyang82

/lgtm

yanmxa avatar Oct 14 '24 05:10 yanmxa

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, yanmxa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [clyang82,yanmxa]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 14 '24 05:10 openshift-ci[bot]

/cherry-pick release-2.12

clyang82 avatar Oct 14 '24 05:10 clyang82

@clyang82: new pull request created: #1164

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherry-pick release-2.12

clyang82 avatar Nov 12 '24 10:11 clyang82

@clyang82: new pull request created: #1217

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.