Christophe Coevoet

Results 2495 comments of Christophe Coevoet

We won't be inventing a feature on our own for those as we intent to implement the Sass language. See https://github.com/sass/sass/issues?q=is%3Aissue+label%3A%22proposal%3A+color+spaces%22+is%3Aopen for the in-progress work on adding support for color...

As support for color spaces has been merged in dart-sass (the Sass website is not updated yet. They will probably merge the PR only when tagging the dart-sass release), I...

What is the use case for creating a new violation from an existing one instead of building the right violation directly ?

Without the mapping metadata corresponding to this `reset_password_request`, this does not allow reproducing the issue.

The implementation does not seem to do what you describe. It still uses the HtmlDumper for all non-CLI SAPIs but uses it also for some cases of CLI SAPIs.

@alexandre-daubois in your condition, anything that is not a CLI SAPI will still use the HtmlDumper. what you changed is that you use the HtmlDumper in *more* cases, not less...

the ability to automatically migrate passwords relies on `\Symfony\Component\PasswordHasher\PasswordHasherInterface::needsRehash` to detect cases where we need to rehash the password (and to attempt to verify it with older encoders). However, MessageDigestPasswordHasher...