Christophe Coevoet

Results 2315 comments of Christophe Coevoet
trafficstars

@gremo if you want to bundle the translator and translations in your webpack build, the simpliest way is probably to use the dumping command to dump the translations to JSON...

Several solutions here: - restructure the bundle to move tests and fixtures outside of the non-dev autoloading root - use `exclude-from-classmap` to exclude the `Tests` folder from the optimized autoloader...

Well, the translation loader controller does not use the request locale to decide what locales should be loaded. It loads what the query string tells it to load (allowing better...

This is broken. If the number is `2`, it will not select the plural anymore, as it will try to use the third alternative (and so on). These rules are...

btw, the fact that tests are not failing for this makes me think that the testsuite is incomplete.

What aboout using the same regex than the one used in the Symfony Translator to restrict valid locales ? https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Translation/Translator.php#L484

@zocimek FYI, you committed with an email address which is not associated to your github account, so Github does not match these contributions as being ours (in the contributor graph...

Given that you accept dashes now, you should normalize them to underscores, to match the Symfony behavior

and I cannot merge this. I'm not a collaborator on the repo

What could be done though is adding a way to configure the translation files to be a JS module too.