Steven Nguyen

Results 1239 comments of Steven Nguyen

@Player256, are you still interested in working on this issue?

@Mushmou, assigned! Thanks for your interest! 🙏🏼

> hi! i would like to be assigned this! @byt3h3ad assigned! Thanks for your interest!

@mustansirgodhrawala, assigned! Thanks for your interest!

@Akshay-Rana-Gujjar any update on this?

@Akshay-Rana-Gujjar, actually, I think this is all good from your end. We just need a final review and then merge.

One challenge I thought about was how to handle these: 1. https://github.com/appwrite/appwrite/blob/02a432102df047d2ea96faed65d77a862239d487/src/Appwrite/Auth/OAuth2.php#L81 1. https://github.com/appwrite/appwrite/blob/02a432102df047d2ea96faed65d77a862239d487/src/Appwrite/Auth/OAuth2.php#L90 1. https://github.com/appwrite/appwrite/blob/02a432102df047d2ea96faed65d77a862239d487/src/Appwrite/Auth/OAuth2.php#L97 However, after looking at [Okta](https://developer.okta.com/docs/reference/api/oidc/#userinfo), [Auth0](https://auth0.com/docs/api/authentication#get-user-info), [Identity Server](https://github.com/IdentityServer/IdentityServer4/blob/5bcc2abbcf6c47200c4eb3b77e756f1bc0e04358/samples/Clients/src/JsOidc/wwwroot/libs/oidc-client.d.ts#L437-L475), [Authentik](https://github.com/goauthentik/authentik/blob/bdf50a35cd50ead063c11e86aa40265ab4bcbd7b/internal/outpost/proxyv2/application/claims.go#L10-L17), and [Keycloak](https://stackoverflow.com/questions/73118975/oauth-to-oidc-keycloak), it seems like...

> They are defined per specification of oidc. So no option is needed @Mabenan, ah you're right! They are [standard claims](https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims). And as you mentioned in https://github.com/appwrite/appwrite/pull/4660#issuecomment-1310934275, the biggest challenge...

Closing as this is resolved with our [1.1.0](https://github.com/appwrite/appwrite/releases/tag/1.1.0) release.