EllipticFunctions.jl icon indicating copy to clipboard operation
EllipticFunctions.jl copied to clipboard

version 2.0.0

Open stla opened this issue 2 years ago • 10 comments

@simonp0420 , @kagalenko-m-b

I've just pushed a new version.

  • better algorithm for the Jacobi theta functions
  • Jacobi theta function with characteristics (it generalizes the four Jacobi theta functions)
  • Based on the Jacobi theta function with characteristics, I redefined _jtheta1dash0, the derivative at 0 of the first Jacobi theta function

The third point has caused a problem: the test of the theta-S Neville function with extended precision has failed, because of a small imaginary part in the result while this result should be a real number. I added atol = 1e-15 in @approx in order that the test succeeded.

stla avatar Oct 21 '23 10:10 stla

Ah I've just had a thought. In the new _jtheta1dash0, there is a call to the generalized Jacobi theta function with a value 1/6. Maybe we should promote the type of 1/6 to the extended precision.

stla avatar Oct 21 '23 10:10 stla

Yes, perfect. I've done 1/(6*one(tau)) and the test is successful!

stla avatar Oct 21 '23 10:10 stla

Would you know how to update the documentation? The page has been last deployed on July 2022. I don't remember how to trigger the update.

stla avatar Oct 23 '23 15:10 stla

Looking at the log of one of your old successful documentation runs I see this: image

simonp0420 avatar Oct 23 '23 16:10 simonp0420

Hmm... would you know where should I add this label?

stla avatar Oct 23 '23 17:10 stla

I see that in the YAML file:

  docs:
    name: Documentation
    runs-on: ubuntu-latest
    if: "contains( github.event.pull_request.labels.*.name, 'preview docs') || github.ref == 'refs/heads/master' || contains(github.ref, 'refs/tags/')"
    ......

So if I push on master, that should generate the doc?

stla avatar Oct 23 '23 17:10 stla

The action is triggered but it is finished after 0 second. I'm lost.

stla avatar Oct 23 '23 17:10 stla

Sorry, those files are black magic to me as well. Maybe ask on Discourse.

simonp0420 avatar Oct 23 '23 19:10 simonp0420

Already asked on Discourse :) I also tried to update the YAML file, with no luck.

stla avatar Oct 23 '23 20:10 stla

I've finally managed! The doc is at https://stla.github.io/EllipticFunctions.jl/dev/ (not at https://stla.github.io/EllipticFunctions.jl/)

stla avatar Oct 23 '23 22:10 stla