PSyclone icon indicating copy to clipboard operation
PSyclone copied to clipboard

(Closes #2537) Added exact_name requirement to the symbol_table find_and_create_tag …

Open LonelyCat124 opened this issue 1 year ago • 1 comments

…function

LonelyCat124 avatar Apr 05 '24 14:04 LonelyCat124

First draft of this also ready for review @sergisiso - the only thing I maybe think we should add is if exact_name is requested and we find a tagged variable, should it have the same name also?

LonelyCat124 avatar Apr 05 '24 15:04 LonelyCat124

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.84%. Comparing base (f64500f) to head (88fedff). Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   99.85%   99.84%   -0.02%     
==========================================
  Files         356      356              
  Lines       47834    46508    -1326     
==========================================
- Hits        47765    46434    -1331     
- Misses         69       74       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 08 '24 13:04 codecov-commenter

@sergisiso Adding something to disallow renaming of UnsupportedFortranTypes has broken how common blocks are created by the fparser2 frontend - is this something I should/can workaround or should we remove that restriction for now?

LonelyCat124 avatar Apr 10 '24 15:04 LonelyCat124

@sergisiso Ready for a nother look, should be a lot closer to a real implementation now

LonelyCat124 avatar Apr 11 '24 14:04 LonelyCat124

@sergisiso Should be ready for a (hopefully) final look.

LonelyCat124 avatar Apr 12 '24 11:04 LonelyCat124