stevenwdv

Results 80 comments of stevenwdv

**EDIT:** nvm fixed it --- Ok, the excessive exploding fix I mentioned above may actually cause problems of its own: `echo '{a: {b: &b 42},

Thanks for having another look! Did you see my comments in the [thread above](https://github.com/mikefarah/yq/pull/2400#discussion_r2210545616) as well? Currently I've actually broken key overriding in regular maps for traversing, and I don't...

Ah spelling is also wrong I see, didn't know this was a bri'ish codebase ;) Edit: apparently the codebase it not entirely consistent, but anyway

> Ok I think to properly fix explode I need to take a step further and rewrite the reconstructAliasedMap - which I've done in a branch `MakeExplodeGreatAgain` Nice, I'll merge...

@mikefarah I notice that `fixedReconstructAliasedMap` in `MakeExplodeGreatAgain` is lacking a lot of logic that is present in `reconstructAliasedMap`. Compare: ``` $ echo '{e: &empty {}, b: &b 42, a: {b2:...

> I'm seeing if I can quickly fix it in the merge. I thought of a way to quickly solve the issue in a different way, by evaluating merge keys...

Ok, it should be all done now, I hope! Well, maybe the tests could be cleaned up a bit / made more consistent between traverse & explode. Btw, I thought...

True, although YAML does act like merge keys come first, so it kinda makes sense in a way

Hey @mikefarah, I'm really confused because it seems like something went really wrong merging this; a lot of changes didn't make it and some logic from `MakeExplodeGreatAgain` that I changed...

@mikefarah I'm a bit sad to see many things that worked with this MR not work anymore. I put in a lot of work to try and get everything right,...