metalsmith-sass icon indicating copy to clipboard operation
metalsmith-sass copied to clipboard

node-sass is deprecated

Open borisovg opened this issue 4 years ago • 6 comments

As per node-sass README (https://github.com/sass/node-sass), the package is deprecated, with the recommendation to switch to Dart Sass package ( https://www.npmjs.com/package/sass).

borisovg avatar Jun 14 '21 14:06 borisovg

Thanks for the heads up @borisovg! We'll have to switch over soon!

stevenschobert avatar Jun 14 '21 14:06 stevenschobert

Hi @stevenschobert - do you have a timeframe on upgrading or accepting !PR64 ? With newer versions, metalsmith-sass does not work anymore due to the outdated gyp dependency of the "old" sass. Thank you!

cproof avatar Dec 14 '21 12:12 cproof

Hey @cproof — thanks for the reminder, and I apologize for the delay!

I just wrapped up a project that has been consuming all my free time, so I should have more time for open source going forward, and will get it merged in!

stevenschobert avatar Dec 15 '21 01:12 stevenschobert

Hi @stevenschobert , thank you for the update and for providing/maintaining this package at all :-)

cproof avatar Dec 15 '21 10:12 cproof

Hey @cproof! I just pushed out v2.0 that changes node-sass to be a peer dependency, so you should be able to pin it at any recent version you like.

I did take a look at the replacement Dart-sass project, but I didn't have enough time to invest in fully switching metalsmith-sass over to it just yet. Hopefully being able to upgrade node-sass does help for the time being.

Thanks!

stevenschobert avatar Jan 08 '22 05:01 stevenschobert

Thank you! This works perfectly 👍 (now using node-sass 6.0.1 in our build)

cproof avatar Jan 11 '22 14:01 cproof