Steven Johnson
Steven Johnson
> Some of the files (e.g. `ASLog.h/.cpp`, `PerfectHashMap.h`, and a few others) are identical and could be merged. Would `autoschedulers/common` be the right place for them? Looks like `ASLog.h/.cpp` are...
> Are there other things that you think should be done or is this ready for review? I think it's ready for review.
I think I know what is going on -- I will apply your patch and then work on a fix
@aekul -- please sync this branch with Halide main, then apply the patch that @vladl-innopeaktech offered in the gist above; I will have an additional patch to apply on top...
Please note: the CMake file uses `add_halide_library(... TARGETS cmake)` in a lot of places; this cannot *possibly* be right for this scheduler, since it requires a GPU feature, but `TARGETS...
OK, per my previous comment, after you sync this to main and apply the other patch, please apply https://gist.github.com/steven-johnson/263f0fafd34ebbac052873d6340ab56f on top of that -- it gets everything building an (apparently)...
> Thanks for the patches. Synced with main and applied both of them. ...are you sure? The GitHub page says there is an unresolved conflict in src/autoschedulers/adams2019/CMakeLists.txt > Regarding `TARGETS...
> That's the part that belongs in src/autoscheduler/.... Tests belong in tests/autoscheduler/ and may have additional dependencies. That's beyond the scope of this PR, unfortunately. We should really refactor the...
> Homebrew is live 🎉 > > ```shell > brew install halide > ``` :HAPPYDANCE:
Update: reading further, there are at least two issues with the current (Mar 2022) version of nanobind: - Eigen and NumPy integration have been removed. - Buffer protocol functionality was...