Steven Johnson

Results 458 comments of Steven Johnson

This PR has been sitting around for a few months now; is it still active?

> @steven-johnson Sorry this PR fell through the cracks. But I think we need this PR. I'll resume working on this. Thanks for the update!

@abadams -- should I pull this into Google and do some torture testing before landing, or are we pretty confident this is good?

Testing in Google, I find only one new failure, but... it appears to be a hang (or near-infinite loop) inside `Bounding small realizations...` when compiling one specific Generator. Adding to...

Yeah, we definitely get stuck ~forever in `bound_small_allocations()`, which was only changed to include the new header, so something about the change in definition has injected something here. Let me...

So far, what I'm finding is that we have a fairly complex Expr that is the input to remove_unbounded_terms: ``` (((let t418 = min(max(min(max(min(max(min(max(min(max(min(max(min(max(min((foo$13.extent.0 + foo$13.min.0) + 4, input.extent.0), 1)...

> Is it possible to know if the scope has any values actually set? Sorry, I didn't realize that printing scope only prints the names, I need the corresponding intervals...

> @steven-johnson Do you think you could run Google testing again? I think my tests just never had such enormous expressions, the example you provided should end reasonably fast now....

(Tests look good so far, stand by)