Steve Kuznetsov
Steve Kuznetsov
At a minimum Andy and I were hoping to get the JSON patch construction and logic around spec/status updates shared. It's currently copied around per-type everywhere.
This has ... obvious drawbacks. :^)
``` $ make build go build -ldflags="-X k8s.io/client-go/pkg/version.gitCommit=eb7bb41e -X k8s.io/client-go/pkg/version.gitTreeState=clean -X k8s.io/client-go/pkg/version.gitVersion=v1.23.5+kcp-v0.5.0-alpha.1-552-geb7bb41e9f713e -X k8s.io/client-go/pkg/version.gitMajor=1 -X k8s.io/client-go/pkg/version.gitMinor=23 -X k8s.io/client-go/pkg/version.buildDate=2022-07-12T15:56:10Z -X k8s.io/component-base/version.gitCommit=eb7bb41e -X k8s.io/component-base/version.gitTreeState=clean -X k8s.io/component-base/version.gitVersion=v1.23.5+kcp-v0.5.0-alpha.1-552-geb7bb41e9f713e -X k8s.io/component-base/version.gitMajor=1 -X k8s.io/component-base/version.gitMinor=23 -X k8s.io/component-base/version.buildDate=2022-07-12T15:56:10Z"...
Depends on #2194
Right now I think we can: - run unit tests [see note] - run integration tests [see note] - compile everything in the repo - build a kind node image...
Only downsides are going to be internal parsing -- when I was adding `tito build --quiet` I noticed there are some places where we parse `rpmbuild` output, etc, so this...
Why wouldn't it be appropriate to place this in `${repo}/.tito/tito.props`? That would allow for it to be repo-specific without any extra mapping necessary.
Enjoying `click` and it's API in the project we have it in FWIW.
@agalue good question about restarts! On process exit, you will lose your in-memory record of the previous version you saw anyway, so that won't be necessary. When the underlying informer...