nix2aci icon indicating copy to clipboard operation
nix2aci copied to clipboard

Published 20 hours ago • verified publisher icon steveej

Annotations

Open Mic92 opened this issue 9 years ago • 6 comments

includes travis ci commits for testing

Mic92 avatar Apr 17 '16 22:04 Mic92

This was included in #12, correct?

steveej avatar Apr 27 '16 10:04 steveej

yes. I have to rebase it first.

Mic92 avatar Apr 27 '16 15:04 Mic92

done

Mic92 avatar Apr 27 '16 17:04 Mic92

How about we include annotations as a set argument instead of breaking them down into 3 distinct ones in the single ACI packages? I'd find that more flexible.

steveej avatar Apr 28 '16 10:04 steveej

This was also my first idea. But the spec recommends to prefix custom annotations with a vendor string. So I thought it would be good to pass the official keys as an explicit argument and probably add later a second attribute, which allows to pass own annotations with an advice watch out for potential namespace pollution. Does this makes sense?

This also needs to consider #6 probably.

Mic92 avatar Apr 28 '16 11:04 Mic92

@Mic92 would you mind rebasing this?

steveej avatar Jun 11 '16 18:06 steveej