overseer.nvim icon indicating copy to clipboard operation
overseer.nvim copied to clipboard

bug: tsc-watch patterns are out of date

Open tmcw opened this issue 1 year ago • 0 comments

Neovim version (nvim -v)

v0.10.1

Operating system/version

macOS Sequoia 15.0 (24A335)

Describe the bug

The $tsc-watch problem matcher in this plugin is modeled after the VS Code extension:

https://github.com/stevearc/overseer.nvim/blob/a2734d90c514eea27c4759c9f502adbcdfbce485/lua/overseer/template/vscode/problem_matcher.lua#L192C11-L192C115

But no longer matches the patterns that the VS Code plugin uses:

https://github.com/microsoft/vscode/blob/28e3fa85666b1d8f7fa03318f86a041430652635/extensions/typescript-language-features/package.json#L1747-L1752

It looks like this was updated about 2 years ago: https://github.com/microsoft/vscode/commit/f0cf1ea129f453b436de3eea8af7bf012bb622dc

What is the severity of this bug?

minor (annoyance)

Steps To Reproduce

  1. Set up a task that uses $tsc-watch as a matcher
  2. Run that task

Expected Behavior

Overseer should acknowledge the Starting compilation in watch mode... initial message

Minimal example file

No response

Minimal init.lua

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  { "stevearc/dressing.nvim", config = true },
  {
    "stevearc/overseer.nvim",
    config = function()

      local overseer = require("overseer")
      overseer.register_template({
        name = "tsc",
        builder = function()
          return {
            cmd = { "npx", "tsc", "--watch" },
            env = {
              NO_COLOR = "1",
            },
            components = {
              { "on_output_quickfix", open = true },
              { "on_output_parse", problem_matcher = "$tsc-watch" },
            },
          }
        end,
      })
    end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Additional context

No response

tmcw avatar Sep 23 '24 14:09 tmcw