soroban-example-dapp icon indicating copy to clipboard operation
soroban-example-dapp copied to clipboard

Update Dockerfile

Open danielcdz opened this issue 1 year ago • 7 comments

Issues related

  • Closes #158

Work done

  • Update Dockerfile accordingly to the main README instrucions
  • Update README
  • Add cargo install_soroban command into .cargo/config.toml

danielcdz avatar Aug 04 '24 21:08 danielcdz

Hello @Julian-dev28! Do you have any feedback?

danielcdz avatar Aug 06 '24 22:08 danielcdz

Hey @danielcdz Thanks for your submission!

I was hoping this bounty would resolve the issues encountered during the local deployment workflow, but it looks like there are still some challenges to address. Specifically, there might be an issue with the quickstart.sh file concerning the Stellar Quickstart SHA version.

It would be helpful if @leighmcculloch could weigh in on the correct SHA to use.

With this fixed, users should be able to run ./initialize.sh standalone and successfully deploy the contracts to the standalone network. Unfortunately, I encountered the following error when attempting to deploy the contracts:

Error: Networking or low-level protocol error: Server returned an error status code: 404

I hope this feedback provides some useful guidance. Looking forward to your next iteration!

Julian-dev28 avatar Aug 13 '24 23:08 Julian-dev28

Hey @danielcdz Thanks for your submission!

I was hoping this bounty would resolve the issues encountered during the local deployment workflow, but it looks like there are still some challenges to address. Specifically, there might be an issue with the quickstart.sh file concerning the Stellar Quickstart SHA version.

It would be helpful if @leighmcculloch could weigh in on the correct SHA to use.

With this fixed, users should be able to run ./initialize.sh standalone and successfully deploy the contracts to the standalone network. Unfortunately, I encountered the following error when attempting to deploy the contracts:

Error: Networking or low-level protocol error: Server returned an error status code: 404

I hope this feedback provides some useful guidance. Looking forward to your next iteration!

Got it, I'll wait for @leighmcculloch for the SHA to use, also @Julian-dev28 I had a question, In the description of the issue I'm trying to solve you mentioned changes and updates in the Dockerfile and docker-compose, but you are mentioning the quickstart.sh and initialize.sh, the changes in the Dockerfile affect these sh files? I just want to know If I'm following the right path

danielcdz avatar Aug 15 '24 16:08 danielcdz

@Julian-dev28 I commented on the thread about the SHA, see above at https://github.com/stellar/soroban-example-dapp/pull/173#discussion_r1719658217.

Regarding quickstart, the stellar-cli now embeds the quickstart, so it would be ideal if this example uses quickstart, that it is used via the stellar-cli. That might mean there is no docker-compose needed, and instead the README can say to first run stellar network contrainer start local and to then run the dapp.

I understand it may be intuitive to say that an approach like that won't be automated enough, but an approach like that is still relatively simple, and it educates a user on how to use the stellar-cli to test against a live network and teaches them how to use the foundational tools. Where-as scripts that try and hide complexity and reduce it all down to a one line command result instead in teaching a developer about those scripts and that approach.

leighmcculloch avatar Aug 16 '24 10:08 leighmcculloch

Thanks for the follow up @leighmcculloch!

Julian-dev28 avatar Aug 17 '24 02:08 Julian-dev28

@danielcdz Keep up the good work. I look forward to reviewing this by next week!

Julian-dev28 avatar Aug 17 '24 02:08 Julian-dev28

@Julian-dev28 @leighmcculloch I removed the install stellar command from the Dockerfile and the config.toml file, I think I'm missing the update in README.md with the suggestion @leighmcculloch made here, but I'm not sure where to add that, any suggestions?

danielcdz avatar Aug 19 '24 18:08 danielcdz