js-stellar-sdk icon indicating copy to clipboard operation
js-stellar-sdk copied to clipboard

EventSource in (dom-monkeypatch.d.ts) is conflicting with EventSource in Typescript lib.dom.d.ts

Open CITGuru opened this issue 1 year ago • 3 comments

Describe the bug EventSource in (dom-monkeypatch.d.ts) is conflicting with EventSource in Typescript lib.dom.d.ts

What version are you on? Latest version - 11.2.1

To Reproduce Steps to reproduce the behavior:

  1. Install Stellar SDK latest version
  2. upgrade typescript version to 5.3.3
  3. Try building the project and you get the error below:
node_modules/stellar-sdk/types/dom-monkeypatch.d.ts:34:12 - error TS2717: Subsequent property declarations must have the same type.  Property 'CLOSED' must be of type '2', but here has type 'number'.

34   readonly CLOSED: number;
              ~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:8171:14
    8171     readonly CLOSED: 2;
                      ~~~~~~
    'CLOSED' was also declared here.

node_modules/stellar-sdk/types/dom-monkeypatch.d.ts:35:12 - error TS2717: Subsequent property declarations must have the same type.  Property 'CONNECTING' must be of type '0', but here has type 'number'.

35   readonly CONNECTING: number;
              ~~~~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:8169:14
    8169     readonly CONNECTING: 0;
                      ~~~~~~~~~~
    'CONNECTING' was also declared here.

node_modules/stellar-sdk/types/dom-monkeypatch.d.ts:36:12 - error TS2717: Subsequent property declarations must have the same type.  Property 'OPEN' must be of type '1', but here has type 'number'.

36   readonly OPEN: number;
              ~~~~

  node_modules/typescript/lib/lib.dom.d.ts:8170:14
    8170     readonly OPEN: 1;
                      ~~~~
    'OPEN' was also declared here.


Found 3 errors in the same file, starting at: node_modules/stellar-sdk/types/dom-monkeypatch.d.ts:34

Additional context I was able to fix this by deleting dom-monkeypatch.d.ts from the package and it worked fine without it

CITGuru avatar Jan 29 '24 14:01 CITGuru

@Shaptic Can you help with this.

CITGuru avatar Jan 29 '24 14:01 CITGuru

There are 2 fix to this:

  1. Delete dom-monkeypatch.d.ts

  2. Update the below variables from

    readonly CLOSED: number;
    readonly CONNECTING: number;
    readonly OPEN: number;
    

    to:

 readonly CLOSED: 2; 
 readonly CONNECTING: 0;
 readonly OPEN: 1; 

CITGuru avatar Jan 29 '24 14:01 CITGuru

https://www.npmjs.com/package/@citguru/stellar-sdk If you are having the same issues. You can easily fix it by using this installation instead

CITGuru avatar Jan 29 '24 16:01 CITGuru