timoni
timoni copied to clipboard
stefanprodan
Update to latest version of CUE
CUE now has resolved the CRD import issue with oneOf, not, and anyOf (#336) as well required fields. This PR integrates latest revision and updates tests.
Adding a bump for gomega, as it gets only a shy +1 as part of CUE bump, might as well get the very latest.
Should we add test cases for all verbs? I think Flagger CRD has only one of them.
v0.11.0 is out so we can move forward with this PR https://github.com/cue-lang/cue/releases/tag/v0.11.0
Just did a quick bump, let's see if CI is happy, will rebase then.
On Tue, 19 Nov 2024 at 20:50, Stefan Prodan @.***> wrote:
v0.11.0 is out so we can move forward with this PR https://github.com/cue-lang/cue/releases/tag/v0.11.0
— Reply to this email directly, view it on GitHub https://github.com/stefanprodan/timoni/pull/424#issuecomment-2486724937, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB5MSZJHD6H63GWK6LXIOL2BOQABAVCNFSM6AAAAABN6SCNAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG4ZDIOJTG4 . You are receiving this because you were mentioned.Message ID: @.***>
@errordeveloper I don't think CI would run if the PR has conflicts, but you can run it locally with make test.
@stefanprodan tests are passing now now, please have a look over the changes, I cannot be too sure of what some of the CUE changes in tests amount to, clearly a few things have changes in 0.11.0.