Stefan Penner

Results 329 comments of Stefan Penner

mysterious node 6 only test failure...

> IMO, the only really useful area this addon serves is testing build code which is not appropriately tested through normal unit tests. It sounds like we should provide helpers...

> Are you saying you'd like to have the builds from the S3 bucket in some sort of drop-down? yes, latest canary, recent betas, and stable releases. (prod/dev versions)

@cowboyd benchmark.js test are a new addition for the micro-level tests, I would like to push them to the macro tests aswell

@fmeum Thanks for responding! for `clean` mode are you referring to [fetch_repo --clean](https://github.com/bazel-contrib/bazel-gazelle/blob/2a65ce83f2fc9cd7022139a621fe7fde8157a85f/cmd/fetch_repo/main.go#L40C2-L40C7)? I believe by default it is [`auto`](https://github.com/bazel-contrib/bazel-gazelle/blob/2a65ce83f2fc9cd7022139a621fe7fde8157a85f/internal/bzlmod/go_deps.bzl#L152-L154), should that change? re: case (2). I __think__, but I...

> @chriseppstein @stefanpenner Could you guys look into merging or rejecting this one? @MaksimBurnin sorry, I don't have any powerz on this repo. We'll have to wait for mr @chriseppstein

I have powerz now, but we should likely only merge this an add actual windows supports once the tests pass in appveyor.

I haven't had much time for bazel stuff recently, but that might be changing. I'll attempt to carv out some time to investigate. FWIW the go work demo was how...

> However the error with this.replaceWith('not-found') still happens. Sounds like this will need to be addressed (updating labels)