leaflet-search icon indicating copy to clipboard operation
leaflet-search copied to clipboard

Are there TypeScript typings for this project?

Open devaskim opened this issue 3 years ago • 6 comments
trafficstars

I am going to use this awesome project to extend capabilities of map widget implemented in Thingsboard IoT platform. The UI of the platform is Angular project, so there is Typescript. My question is: where I can find TypeScript typings?

devaskim avatar Sep 27 '22 17:09 devaskim

leaflet was not written in typescript

stefanocudini avatar Oct 23 '22 20:10 stefanocudini

@stefanocudini Sorry, but not a serious answer. Leaflet has official typings or type definitions to use it in Typescript-ed project.

devaskim avatar Oct 24 '22 06:10 devaskim

@stefanocudini Sorry, but not a serious answer. Leaflet has official typings or type definitions to use it in Typescript-ed project.

may be it's official for github.com/DefinitelyTyped not for Leaflet organization..

stefanocudini avatar Oct 24 '22 09:10 stefanocudini

@stefanocudini Thanks for your time but our discussion is out of scope of original question. I think you agree with me.

Let's start from the beginning

  1. Do you have plans to add Typescripts type definitions for your plugin?
  2. Here is unofficial attempt to create type definitions, but that was a long time ago and I could success with it.

I'm not an experienced Typescript developer to do such job so I decided to ask for help there.

devaskim avatar Oct 24 '22 09:10 devaskim

  1. Do you have plans to add Typescripts type definitions for your plugin? no
  1. Here is unofficial attempt to create type definitions, but that was a long time ago and I could success with it.

it sounds interesting but I don't know Typescripts and I have no idea how this works, however the types for the options all seem right: https://github.com/bastisk/leaflet-search-types/blob/master/index.d.ts#L5

stefanocudini avatar Oct 24 '22 13:10 stefanocudini

I leave the issue open if anyone TP dev wants to contribute with a PR

stefanocudini avatar Oct 24 '22 13:10 stefanocudini