system-lambda icon indicating copy to clipboard operation
system-lambda copied to clipboard

Sanitise README and tests to help other contributors

Open ashleyfrieze opened this issue 5 years ago • 2 comments
trafficstars

  • fix minor typos
  • allow tests to pass when run in IntelliJ (avoid unrunnable test classes)
  • enhance info about building and running tests

ashleyfrieze avatar Nov 08 '20 19:11 ashleyfrieze

Thanks for your work.

The changes in README.md have been merged: 8903a1df2fb6238364e340c45946162791c0734c.

I still think about whether to merge the change with abstract. Not sure about this. I want to first try out something with JUnit Jupiter.

I will not merge the .gitignore changes (see #7 for details).

stefanbirkner avatar Nov 09 '20 20:11 stefanbirkner

Thanks for your work.

The changes in README.md have been merged: 8903a1d.

I still think about whether to merge the change with abstract. Not sure about this. I want to first try out something with JUnit Jupiter.

I will not merge the .gitignore changes (see #7 for details).

If a test base class cannot be run directly, then it should be abstract that's been true for JUnit4 and 5. It's another nicety to people running tests in their IDEs.

As we discussed in #9, I'm forking out this codebase to create something which allows many more patterns of invocation. As I do so, I'll try to contribute back any fixes for glitches that I find in the core code. It's up to you whether you include them, but it's only fair to pay you back with any improvements that translate into your paradigm.

ashleyfrieze avatar Nov 09 '20 23:11 ashleyfrieze