stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

Published 20 hours ago • verified publisher icon stdlib-js

feat: add support for replacing a substring after the first occurrence of a search string

Open HarshitaKalani opened this issue 2 years ago • 8 comments

Resolves #812 .

With this PR, I'm adding the implementation for replace-after issue.

@stdlib-js/reviewers

HarshitaKalani avatar Feb 24 '23 19:02 HarshitaKalani

@HarshitaKalani For this implementation, you can leave out the CLI and input validation. I've updated @stdlib/string/base/replace-before accordingly, which you can use as a reference when building out this package. LMK if you have any questions!

kgryte avatar Feb 25 '23 00:02 kgryte

Hey @kgryte , please have a review and lmk if anything needs to be updated.

HarshitaKalani avatar Feb 25 '23 17:02 HarshitaKalani

@kgryte please have a review.

HarshitaKalani avatar Feb 28 '23 12:02 HarshitaKalani

@HarshitaKalani Am I correct in thinking that this PR is complete and ready for review?

kgryte avatar Mar 02 '23 07:03 kgryte

Hey @kgryte , please review it and suggest me a good issue to pick next.

HarshitaKalani avatar Mar 08 '23 02:03 HarshitaKalani

@HarshitaKalani Thanks for following up with comments!

kgryte avatar Mar 26 '23 09:03 kgryte

image

I'm getting this linting error whenever I try to commit. Please suggest how to get over with the error.

HarshitaKalani avatar Apr 02 '23 07:04 HarshitaKalani

Try upgrading to the latest version of Node.js (eg, v18).

kgryte avatar Apr 02 '23 08:04 kgryte