stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

Add support for computing the derivative of cardinal sine (cosc)

Open Rinbo opened this issue 6 years ago • 1 comments

Resolves #224.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • [x] Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • [x] Read and understand the Code of Conduct.
  • [x] Read and understood the licensing terms.
  • [x] Searched for existing issues and pull requests before submitting this pull request.
  • [x] Filed an issue (or an issue already existed) prior to submitting this pull request.
  • [x] Rebased onto latest develop.
  • [x] Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

  • Add a function to calculate the derivative of the cardinal sine in accordance with the following request: https://github.com/stdlib-js/stdlib/issues/224

Related Issues

Does this pull request have any related issues? No This pull request:

  • resolves #224

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The Julia implementation of cosc(x) went bananas for approximately every tenth value of x in the tiny negative and tiny positive test range To make the tests pass I decided to just skip these fixture values (often in the range of 1e+300 when in fact they should be ~0).


@stdlib-js/reviewers

Rinbo avatar Mar 14 '19 22:03 Rinbo

@Rinbo Thanks for working on this! Will review later this evening!

kgryte avatar Mar 15 '19 01:03 kgryte