stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

Published 20 hours ago • verified publisher icon stdlib-js

[RFC]: refactor `blas/ext/base/snansumkbn2` to follow current project conventions

Open Planeshifter opened this issue 1 year ago • 3 comments

Description

This RFC proposes refactoring @stdlib/blas/ext/base/snansumkbn2 to follow current project conventions.

These conventions are outlined in more detail in https://github.com/stdlib-js/stdlib/issues/788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include https://github.com/stdlib-js/stdlib/commit/d66d80cfcbab1da95cb5ae8cfae4a1fc4c5129d1 (saxpy), https://github.com/stdlib-js/stdlib/commit/3c82fe7b6c0f9fd6ef02c86d6e2024d708ac8c14 (cswap), and https://github.com/stdlib-js/stdlib/commit/5b15c9675be434c0e11b1ec1e1f78d7b089abbcd (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • [X] I have read and understood the Code of Conduct.
  • [X] Searched for existing issues and pull requests.
  • [X] The issue name begins with RFC:.

Planeshifter avatar Mar 03 '24 01:03 Planeshifter

@Planeshifter Can i take up the issue ?

Tushar98644 avatar Mar 04 '24 14:03 Tushar98644

Sure! Thanks for taking this on!

Planeshifter avatar Mar 04 '24 14:03 Planeshifter

@Planeshifter @kgryte as this refactoring is related to my last few issues, would you mind if I work on this if no one is working on this?

vr-varad avatar Apr 07 '24 06:04 vr-varad