status-network-token

status-network-token copied to clipboard

Grifmareview

3

Adding tests. After pulling the latest changes two (new) tests that were previously ok now throw invalid opcode Will look into this tomorrow, although these are both cases where a...

grifma

SGTExchanger.sol collect() Abnormal Gas Cost

2

SGT holders could be faced to an abnormal gas cost when collecting their corresponding SNT: balance and account variables are set via a call to getValueAt(..., finalizedBlock). Problem is that...

k4ms

Collect minimum should be useful during initial rounds.

3

https://github.com/status-im/status-network-token/blob/master/migrations/2_deploy_contracts.js#L60-L64 The last parameter, `collectMinimum` is currently set to 10^12. This means that the min per-transaction buy-in is about $0.00035 USD. This is significantly less than the cost of gas...

MicahZoltu

Makes it easier to reveal the curve by copy pasting.

nfnty

Medium - MiniMeToken.sol - checks not done properly

2

As stated in the Solidity docs (http://solidity.readthedocs.io/en/develop/security-considerations.html#use-the-checks-effects-interactions-pattern), it is much safer to use the Checks-Effects-Interactions Pattern. We can see 3 occurrences in the source code of MiniMeToken.sol where this pattern...

k4ms

Low - 'if(!condition) throw;' should be avoided

1

This concerns many occurrences in source files MultiSigWallet.sol and MiniMeToken.sol. There are several reason to use 'require(condition);' instead of 'if(!condition) throw;' : 1. Faster execution, consumes less gas 2. More...

k4ms

In 'MiniMeToken.sol' the updateValueAtNow() function adds levels of complexity than can be avoided: - calling push() is cheaper than increasing the checkpoint length and assigning value to the struct -...

k4ms

https://contribute.status.im/status-terms.pdf Section 2.2 Token Pools ``` Pool D consisting of 29% of the SNT of Pool A ​, intended as a reserve for future Contribution Periods will be created by...

ethers

Do another round of auditing.

1

There have been _substantial_ changes to the contracts since the audits took place. You can see the full diffs here for each audit relative to current master: https://github.com/status-im/status-network-token/compare/2152b17aa2ef584a2aea95533c707a345c6ccf69...master https://github.com/status-im/status-network-token/compare/ef163f1b6fd6fb0630a4b8c78d3b706f3fe1da33...master Included...

MicahZoltu

Bumps [qs](https://github.com/ljharb/qs) from 6.3.2 to 6.3.3. Changelog Sourced from qs's changelog. 6.3.3 [Fix] parse: ignore __proto__ keys (#428) [Fix] fix for an impossible situation: when the formatter is called with...

dependabot[bot]