status-mobile
status-mobile copied to clipboard
status-im
WIP: Asset to Pay / Asset to Receive
fixes #20332 fixes #20333
Summary
...
Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx
Review notes
Testing notes
Platforms
- Android
- iOS
- macOS
- Linux
- Windows
Areas that maybe impacted
Functional
- 1-1 chats
- public chats
- group chats
- wallet / transactions
- dapps / app browsing
- account recovery
- new account
- user profile updates
- networks
- mailservers
- fleet
- bootnodes
Non-functional
- battery performance
- CPU performance / speed of the app
- network consumption
Steps to test
- Open Status
- ...
- Step 3, etc.
Before and after screenshots comparison
| Figma (if available) | iOS (if available) | Android (if available) |
|---|---|---|
| Please embed Image/Video here of the before and after. | Please embed Image/Video here of the before and after. | Please embed Image/Video here of the before and after. |
status: ready
Jenkins Builds
Click to see older builds (114)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | 2ea82bd5 | #1 | 2024-08-28 14:31:48 | ~6 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 2ea82bd5 | #1 | 2024-08-28 14:35:17 | ~9 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 2ea82bd5 | #1 | 2024-08-28 14:36:46 | ~10 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 2ea82bd5 | #1 | 2024-08-28 15:08:57 | ~43 min | ios |
:iphone:ipa :calling: |
| :x: | 966bc97d | #2 | 2024-08-29 13:23:21 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 966bc97d | #2 | 2024-08-29 13:27:07 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 966bc97d | #2 | 2024-08-29 13:27:30 | ~6 min | android |
:robot:apk :calling: |
| :x: | 966bc97d | #2 | 2024-08-29 13:30:33 | ~9 min | ios |
:page_facing_up:log |
| :x: | 29ecd468 | #3 | 2024-08-29 13:40:23 | ~8 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 29ecd468 | #3 | 2024-08-29 13:41:35 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 29ecd468 | #3 | 2024-08-29 13:44:26 | ~12 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 29ecd468 | #3 | 2024-08-29 13:46:30 | ~14 min | android |
:robot:apk :calling: |
| :x: | 63c18d4f | #4 | 2024-08-30 15:11:01 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 63c18d4f | #4 | 2024-08-30 15:15:16 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 63c18d4f | #4 | 2024-08-30 15:15:57 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 63c18d4f | #4 | 2024-08-30 15:16:55 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | 306115ac | #5 | 2024-09-04 13:08:37 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 306115ac | #5 | 2024-09-04 13:13:13 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 306115ac | #5 | 2024-09-04 13:13:33 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 306115ac | #5 | 2024-09-04 13:16:56 | ~11 min | ios |
:iphone:ipa :calling: |
| :x: | de3d5b4d | #8 | 2024-09-06 13:27:09 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | de3d5b4d | #8 | 2024-09-06 13:30:57 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | de3d5b4d | #8 | 2024-09-06 13:31:27 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | de3d5b4d | #8 | 2024-09-06 13:35:08 | ~10 min | ios |
:iphone:ipa :calling: |
| :x: | ccc04e4e | #9 | 2024-09-06 18:49:18 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | ccc04e4e | #9 | 2024-09-06 18:54:19 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | ccc04e4e | #9 | 2024-09-06 18:54:32 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | ccc04e4e | #9 | 2024-09-06 18:59:28 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | 6c706ab4 | #10 | 2024-09-06 19:05:13 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 6c706ab4 | #10 | 2024-09-06 19:09:12 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 6c706ab4 | #10 | 2024-09-06 19:09:50 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 6c706ab4 | #10 | 2024-09-06 19:15:46 | ~13 min | ios |
:iphone:ipa :calling: |
| :x: | f1a2576c | #11 | 2024-09-08 13:04:35 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | f1a2576c | #11 | 2024-09-08 13:08:24 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | f1a2576c | #11 | 2024-09-08 13:09:20 | ~7 min | android |
:robot:apk :calling: |
| :x: | e9f6227a | #12 | 2024-09-08 13:13:38 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | e9f6227a | #12 | 2024-09-08 13:18:06 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | e9f6227a | #12 | 2024-09-08 13:18:14 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | e9f6227a | #12 | 2024-09-08 13:21:02 | ~10 min | ios |
:iphone:ipa :calling: |
| :x: | 7ea1adc5 | #13 | 2024-09-09 08:19:41 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 7ea1adc5 | #13 | 2024-09-09 08:24:18 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 7ea1adc5 | #13 | 2024-09-09 08:24:43 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 7ea1adc5 | #13 | 2024-09-09 08:26:43 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | bcdc558c | #14 | 2024-09-09 09:44:53 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | bcdc558c | #14 | 2024-09-09 09:49:24 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | bcdc558c | #14 | 2024-09-09 09:49:50 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | bcdc558c | #14 | 2024-09-09 09:51:43 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | 9a210d40 | #15 | 2024-09-12 09:27:30 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 9a210d40 | #15 | 2024-09-12 09:32:26 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 9a210d40 | #15 | 2024-09-12 09:33:54 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 9a210d40 | #15 | 2024-09-12 09:38:25 | ~13 min | ios |
:iphone:ipa :calling: |
| :x: | dbe880ad | #16 | 2024-09-13 08:28:48 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | dbe880ad | #16 | 2024-09-13 08:33:22 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | dbe880ad | #16 | 2024-09-13 08:33:46 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | dbe880ad | #16 | 2024-09-13 08:36:45 | ~10 min | ios |
:iphone:ipa :calling: |
| :x: | 4534d554 | #17 | 2024-09-13 16:31:57 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 4534d554 | #17 | 2024-09-13 16:36:33 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 4534d554 | #17 | 2024-09-13 16:36:55 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 4534d554 | #17 | 2024-09-13 16:39:46 | ~10 min | ios |
:iphone:ipa :calling: |
| :x: | c4a84bb8 | #18 | 2024-09-16 07:19:56 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | c4a84bb8 | #18 | 2024-09-16 07:24:25 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | c4a84bb8 | #18 | 2024-09-16 07:24:27 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | c4a84bb8 | #18 | 2024-09-16 07:30:39 | ~13 min | ios |
:iphone:ipa :calling: |
| :x: | 1866a489 | #20 | 2024-09-16 14:44:00 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 1866a489 | #20 | 2024-09-16 14:47:36 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 1866a489 | #20 | 2024-09-16 14:47:52 | ~6 min | android-e2e |
:robot:apk :calling: |
| :x: | 606fbf28 | #21 | 2024-09-16 14:55:13 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 606fbf28 | #21 | 2024-09-16 14:59:18 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 606fbf28 | #21 | 2024-09-16 15:01:36 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 606fbf28 | #21 | 2024-09-16 15:05:18 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | e8975982 | #23 | 2024-09-19 12:02:31 | ~2 min | tests |
:page_facing_up:log |
| :x: | fe3aa38b | #24 | 2024-09-19 12:08:24 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | fe3aa38b | #24 | 2024-09-19 12:13:15 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | fe3aa38b | #24 | 2024-09-19 12:14:42 | ~8 min | android |
:robot:apk :calling: |
| :x: | 052e412c | #25 | 2024-09-19 12:24:21 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 052e412c | #25 | 2024-09-19 12:29:04 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 052e412c | #25 | 2024-09-19 12:30:33 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 052e412c | #25 | 2024-09-19 12:31:12 | ~10 min | ios |
:iphone:ipa :calling: |
| :x: | cd210eee | #26 | 2024-09-20 15:06:23 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | cd210eee | #26 | 2024-09-20 15:10:10 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | cd210eee | #26 | 2024-09-20 15:10:36 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | cd210eee | #26 | 2024-09-20 15:22:05 | ~18 min | ios |
:iphone:ipa :calling: |
| :x: | 82fa774a | #27 | 2024-09-25 06:32:48 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 82fa774a | #27 | 2024-09-25 06:37:33 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 82fa774a | #27 | 2024-09-25 06:38:02 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 82fa774a | #27 | 2024-09-25 06:42:29 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | 97a86405 | #28 | 2024-09-25 08:26:38 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 97a86405 | #28 | 2024-09-25 08:29:56 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 97a86405 | #28 | 2024-09-25 08:31:41 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 97a86405 | #28 | 2024-09-25 08:35:50 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | dd2fcae2 | #29 | 2024-09-25 08:41:08 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | dd2fcae2 | #29 | 2024-09-25 08:45:10 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | dd2fcae2 | #29 | 2024-09-25 08:46:16 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | dd2fcae2 | #29 | 2024-09-25 08:51:03 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | 3d440d6b | #30 | 2024-09-25 13:06:05 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 3d440d6b | #30 | 2024-09-25 13:10:36 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 3d440d6b | #30 | 2024-09-25 13:11:02 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 3d440d6b | #30 | 2024-09-25 13:17:01 | ~13 min | ios |
:iphone:ipa :calling: |
| :x: | 97cb567d | #32 | 2024-09-25 15:03:12 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 97cb567d | #32 | 2024-09-25 15:07:36 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 97cb567d | #32 | 2024-09-25 15:07:51 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 97cb567d | #32 | 2024-09-25 15:12:47 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | e8f1fd37 | #34 | 2024-09-26 12:37:04 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | e8f1fd37 | #34 | 2024-09-26 12:40:50 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | e8f1fd37 | #34 | 2024-09-26 12:41:42 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | e8f1fd37 | #34 | 2024-09-26 12:47:33 | ~13 min | ios |
:iphone:ipa :calling: |
| :x: | 6c7666d3 | #35 | 2024-09-26 18:25:10 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 6c7666d3 | #35 | 2024-09-26 18:28:28 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 6c7666d3 | #35 | 2024-09-26 18:29:46 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 6c7666d3 | #35 | 2024-09-26 18:34:21 | ~12 min | ios |
:iphone:ipa :calling: |
| :x: | f6b3a922 | #36 | 2024-09-26 18:47:08 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | f6b3a922 | #36 | 2024-09-26 18:50:36 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | f6b3a922 | #36 | 2024-09-26 18:51:59 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | f6b3a922 | #36 | 2024-09-26 18:56:12 | ~11 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | 231cc5bf | #37 | 2024-09-27 07:12:38 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 231cc5bf | #37 | 2024-09-27 07:17:10 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 231cc5bf | #37 | 2024-09-27 07:17:42 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 231cc5bf | #37 | 2024-09-27 07:21:44 | ~11 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | d333e181 | #39 | 2024-09-27 10:17:44 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | d333e181 | #39 | 2024-09-27 10:21:44 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | d333e181 | #39 | 2024-09-27 10:22:12 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | d333e181 | #39 | 2024-09-27 10:25:21 | ~12 min | ios |
:iphone:ipa :calling: |
:heavy_check_mark: status-mobile/prs/android-e2e/PR-21140#8 :small_blue_diamond: ~6 min 25 sec :small_blue_diamond: de3d5b4d :small_blue_diamond: :package: android-e2e package
Hi @alwx
It'd be great if you add a section with the steps to test and also some demo screenshots or video of it working to the description. It'll also help QA to test this PR
There has been a lot of files changed, so any additional note on the code will also help. :+1:
Thank you!
If it depends on #21139 maybe would be better to use #21139 branch (feature/20380) as the base branch so we can review the relevant changes in this PR
Does this PR includes integration within the swap flow or just the screens? In case is just the screens, maybe add a way to open them so QA can test them in isolation, and add intruction in the PR description.
@briansztamfater @status-im/mobile-qa the integration is done as well. This is how it works:
https://github.com/user-attachments/assets/fe09a495-0404-47e9-a311-77903a6dbd93
Hi @alwx, could you please resolve the existing conflicts and rebase the current PR if it's ready for testing? Thanks!
@VolodLytvynenko seems like this PR has already been tested in https://github.com/status-im/status-mobile/pull/21269 because that PR is based on this one?
@VolodLytvynenko seems like this PR has already been tested in #21269 because that PR is based on this one?
@alwx got it. Thanx for clarification
0% of end-end tests have passed
Total executed tests: 7
Failed tests: 7
Expected to fail tests: 0
Passed tests: 0
IDs of failed tests: 727231,727230,702745,702742,703133,702843,727229
Failed tests (7)
Click to expand
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_message_edit, id: 702843 |
Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
Device 1: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
Device 1: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
Device 1: |
| 2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
|
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Hi @alwx thank you for PR. Take a look found issues.
ISSUE 1: Unsupported tokens by network are shown in the "Asset to Pay" / "Asset to Receive" list
Steps:
- Restore a user account that holds tokens unsupported on certain networks but available on several networks.
- Select a token available on multiple networks (e.g., ETH).
- Choose the Optimism or Arbitrum network from the available options in the drawer.
- Navigate to the swap page.
- Open the "Asset to Pay" or "Asset to Receive" list.
- Check whether unsupported tokens for the current network are displayed
Actual Result:
Unsupported tokens for the selected network are shown in the "Asset to Pay" / "Asset to Receive" list, this leads to that we can prosseds
e.g., Arbitrum token not supported on Optimism network Optimism token not supported on Arbitrum network
https://github.com/user-attachments/assets/9306ab2c-3889-430d-b776-576c735d0e8a
Expected Result:
Only tokens supported by the selected network should be displayed in the "Asset to Pay" / "Asset to Receive" list.
ISSUE 2 Blinks occur after tapping the search field
Steps:
- Go to the swap page.
- Open "Select asset to pay" or "Asset to receive."
- Tap the search field.
Actual result:
- On Android, the screen blinks after tapping the search asset field.
https://github.com/user-attachments/assets/cddf72b0-c579-4a68-a55a-14775b930bf8
- On iOS, the keyboard does not open smoothly after tapping the search asset field.
https://github.com/user-attachments/assets/ba1efedc-1bb9-4527-ab92-32057bda8245
Expected result:
No blinks or on Android. The keyboard should open smoothly on iOS without delay.
Devices:
- Pixel 7a, Android 13
- iPhone 11 Pro Max, IOS 17
ISSUE 3: The 'Approve' button is shown, inspite the approve button is not related to certain token
Steps:
- Go to swap page
- Select any ERC-20 non-approved token (e.g. DAI)
- Enter some value (e.g. 1 DAI)
- Open asset to pay screen
- Select any other token (e.g. ETH or token which already approved)
Actual result:
- The 'Approve' button is shown, inspite the approve button is not related to ETH token, this button appears only for ERC-20 tokens
https://github.com/user-attachments/assets/8896a77a-de43-4232-9198-dca68292c57d
Expected result:
After selecting a new token, the "Approve" button should appear for tokens only for those that require approval
I believe this issue is related to issue 3
ISSUE 4: "Review Swap" button is enabled after selection new token within Asset to Pay screen even when the user lacks sufficient tokens to perform the swap
Steps:
- Restore a user account with at least 2 tokens.
- Navigate to the swap page.
- Select an ERC-20 approved token (e.g., DAI).
- Enter a valid available amount (e.g., 1 DAI).
- Open the "Asset to Pay" screen.
- Select a token that the user does not have enough balance for (e.g., Wrapped Bitcoin or ETH).
Actual result:
The "Review Swap" button remains enabled, allowing the user to proceed with the swap, even though there aren't enough tokens for the transaction.
https://github.com/user-attachments/assets/0e49e444-339d-4238-9d36-650312f1cebb
Expected result:
The "Review Swap" button should be disabled if the user doesn't have sufficient assets for the newly selected token.
Devices:
Pixel 7a, Android 13 iPhone 11 Pro Max, iOS 17
ISSUE 5: The default tokens are shown as disabled on "Asset to Pay" page if those tokens are with 0 value
Steps:
- Create new account or restore an account without any assets
- Go to "Asset to Pay" page
Actual result:
Default tokens like SNT, DAI, and ETH are shown as disabled in the "Your assets on Mainnet" section if they have a 0 balance.
Expected result:
Tokens with a 0 balance should not be displayed. Only tokens with available assets should be shown.
PR_ISSUE 6: "Popular assets on "network" " section is not shown within "Asset to Pay" sheet
Steps:
- Open Asset to Pay sheet
Actual result:
Expected result:
Popular assets on
Devices:
- Pixel 7a, Android 13
- iPhone 11 Pro Max, IOS 17
ISSUE 7: The token is not disabled in the "Asset to Pay" sheet if the same token is already selected in the "Receive" section
Steps:
- Go to the swap page.
- Select a token for the "Receive" section (e.g., ETH).
- Open the "Asset to Pay" sheet.
Actual result:
The same token (e.g., ETH) is not disabled in the "Asset to Pay" sheet even though it is already selected in the "Receive" section.
https://github.com/user-attachments/assets/ec6759ea-e3ac-4b0c-8b45-40d5ea03a721
Expected result:
The token selected in the "Receive" section should be disabled in the "Asset to Pay" sheet to prevent swaping on the same token
How it works on a desktop:
https://github.com/user-attachments/assets/ac33b76e-4fef-463d-818d-7ca68f8560eb
57% of end-end tests have passed
Total executed tests: 7
Failed tests: 3
Expected to fail tests: 0
Passed tests: 4
IDs of failed tests: 727230,703133,727229
Failed tests (3)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
Device 1: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Passed tests (4)
Click to expand
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
33% of end-end tests have passed
Total executed tests: 3
Failed tests: 2
Expected to fail tests: 0
Passed tests: 1
IDs of failed tests: 727230,727229
Failed tests (2)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Passed tests (1)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
Hi @alwx thank you for fixes. Take a look found issues:
Issue 1 is not fully resolved yet. Tokens not supported by the current network can still be found and selected. However, our validation prevents transactions from proceeding with these tokens, so this issue can be considered a follow-up.
Steps:
- Navigate to the swap page.
- Open the "Asset to Pay" or "Asset to Receive" list.
- Search for unsupported tokens (example: if network is Optimism, then search for Arb token)
- Check whether unsupported tokens for the current network are displayed
Actual Result:
Unsupported tokens for the selected network are shown in the "Asset to Pay" / "Asset to Receive" list
https://github.com/user-attachments/assets/db40e1c2-5333-464e-a4c8-f7093f1da436
@alwx Apologies for message https://github.com/status-im/status-mobile/pull/21140#issuecomment-2373767725. Ignore it please. Issue is fixed
Issue 2 is not fixed yet; the blinks are still shown. However, this can be considered a follow-up.
- Pixel 7a, Android 13
https://github.com/user-attachments/assets/c19bd477-d0c8-498f-b2de-7ba69b8d588c
- iPhone 11 Pro Max, IOS 17
https://github.com/user-attachments/assets/8f564a5a-155c-4308-9957-a0cd3a98e430
ISSUE 8: Receive value is not recalculated correctly when new token is selected within Asset to Receive sheet until autorefresh
Steps:
- Go swap page
- Prefulfill into Send field
- Change token in recieve value
- Check recalculation in receive value
Actual result:
The value in the Receive field is incorrectly calculated. For example:
- Initial conversion: DAI 1 -> ETH 0.00037
- After changing ETH to USDC, it shows: DAI 0.01 -> USDC 378915182.67 instead of DAI 0.01 -> USDC 0.0096.
https://github.com/user-attachments/assets/06344560-5591-4abd-b1b8-775bed3af093
Expected result:
When the token is changed, the data should be recalculated and displayed correctly. An update or upload statement should be shown reflecting the new calculation.
Current issue is with very low priority and can be considered in 2.32 as follow up
issue 5 is partially fixed. The default tokens are no longer shown as disabled, which is resolved. However, when switching to Network 2, tokens like SNT, DAI, and ETH that exist on Network 1 are shown with a value of 0 on the "Your assets on Mainnet" section, even though they are not present on Network 2
Steps:
- Create new account or restore an account with snt, dai or eth only on Network 1
- Select Network 2 for swapping on which tokens are not present, but present on Network 1
- Go to "Asset to Pay" page
Actual result:
Default tokens (SNT, DAI, ETH) are displayed with a 0 value in the "Your assets on Mainnet" section, even though they are available on Network 1 but not on Network 2, while Network 2 is selected.
Expected result:
Tokens should not be shown in "Your assets on Mainnet" section if they are not available on the currently selected network. https://figma.com/design/AD2JSKg0I8dZcylyiGa62O/Swap-for-Mobile?node-id=76-130105&node-type=frame&t=mccNGM33NrJBogCP-0