status-mobile Fix send no bonder fee included

fixes #21097

Summary

For the "Recipient gets" field, show the estimated-received amount that takes into account the bonder fee, which would be equivalent to amount-in - tx-token-fees according to this line.

Platforms

Android
iOS

Areas that maybe impacted

Functional

wallet / transactions

status: ready

Aug 22 '24 15:08 clauxx

Jenkins Builds

Click to see older builds (72)

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_check_mark:	45a81418	#1	2024-08-22 15:33:07	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	45a81418	#1	2024-08-22 15:36:24	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	45a81418	#1	2024-08-22 15:36:48	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	45a81418	#1	2024-08-22 15:38:24	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	322ab3aa	#2	2024-08-29 14:02:02	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	322ab3aa	#2	2024-08-29 14:05:34	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	322ab3aa	#2	2024-08-29 14:05:59	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	322ab3aa	#2	2024-08-29 14:07:39	~9 min	`ios`	:iphone:`ipa` :calling:

:x:	538a4ea4	#3	2024-09-02 12:27:48	~3 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	538a4ea4	#3	2024-09-02 12:31:13	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	538a4ea4	#3	2024-09-02 12:32:29	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	538a4ea4	#3	2024-09-02 12:35:42	~10 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	8c799338	#4	2024-09-03 12:20:58	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	8c799338	#4	2024-09-03 12:22:37	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	8c799338	#4	2024-09-03 12:24:25	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	8c799338	#4	2024-09-03 12:28:04	~11 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	3e15b644	#5	2024-09-17 13:11:47	~5 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	3e15b644	#5	2024-09-17 13:14:12	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	3e15b644	#5	2024-09-17 13:14:15	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	3e15b644	#5	2024-09-17 13:19:28	~12 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	a80d79d2	#6	2024-10-03 10:33:21	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	a80d79d2	#6	2024-10-03 10:36:21	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	a80d79d2	#6	2024-10-03 10:37:00	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	a80d79d2	#6	2024-10-03 10:39:10	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	467928fc	#7	2024-10-10 10:30:32	~3 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	467928fc	#7	2024-10-10 10:33:54	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	467928fc	#7	2024-10-10 10:34:23	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	467928fc	#7	2024-10-10 10:35:10	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	b32a99be	#8	2024-10-11 09:45:49	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	b32a99be	#8	2024-10-11 09:48:59	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	b32a99be	#8	2024-10-11 09:50:16	~9 min	`ios`	:iphone:`ipa` :calling:
:heavy_check_mark:	b32a99be	#8	2024-10-11 09:50:20	~9 min	`android`	:robot:`apk` :calling:

:heavy_check_mark:	fe6e3803	#9	2024-10-11 14:26:24	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	fe6e3803	#9	2024-10-11 14:30:33	~8 min	`ios`	:iphone:`ipa` :calling:
:heavy_check_mark:	fe6e3803	#9	2024-10-11 14:30:39	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	fe6e3803	#9	2024-10-11 14:32:51	~10 min	`android-e2e`	:robot:`apk` :calling:

:x:	6ce553a6	#10	2024-10-22 19:53:17	~2 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	6ce553a6	#10	2024-10-22 19:57:53	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	6ce553a6	#10	2024-10-22 19:58:20	~8 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	6ce553a6	#10	2024-10-22 19:59:00	~8 min	`ios`	:iphone:`ipa` :calling:

:x:	7125701d	#11	2024-10-23 06:51:51	~2 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	7125701d	#11	2024-10-23 06:56:34	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	7125701d	#11	2024-10-23 06:56:42	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	7125701d	#11	2024-10-23 06:57:53	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	c189865f	#12	2024-10-23 07:36:03	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	c189865f	#12	2024-10-23 07:38:06	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	c189865f	#12	2024-10-23 07:39:30	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	c189865f	#12	2024-10-23 07:40:16	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	98b8e078	#14	2024-10-23 09:12:20	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	98b8e078	#14	2024-10-23 09:14:52	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	98b8e078	#14	2024-10-23 09:15:45	~8 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	98b8e078	#14	2024-10-23 09:16:27	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	15b0a690	#15	2024-10-23 09:37:46	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	15b0a690	#15	2024-10-23 09:39:44	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	15b0a690	#15	2024-10-23 09:40:46	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	15b0a690	#15	2024-10-23 09:42:44	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	e825e279	#16	2024-10-24 08:42:05	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	e825e279	#16	2024-10-24 08:44:23	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	e825e279	#16	2024-10-24 08:45:12	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	e825e279	#16	2024-10-24 08:46:03	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	54c876f3	#17	2024-11-01 09:53:42	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	54c876f3	#17	2024-11-01 09:56:38	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	54c876f3	#17	2024-11-01 09:57:13	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	54c876f3	#17	2024-11-01 09:57:33	~8 min	`ios`	:iphone:`ipa` :calling:

:x:	6acda08e	#20	2024-11-04 18:19:51	~3 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	6acda08e	#20	2024-11-04 18:22:58	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	6acda08e	#20	2024-11-04 18:24:56	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	6acda08e	#20	2024-11-04 18:26:02	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	65e00c6f	#21	2024-11-05 15:50:56	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	65e00c6f	#21	2024-11-05 15:54:06	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	65e00c6f	#21	2024-11-05 15:54:32	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	65e00c6f	#21	2024-11-05 15:55:10	~8 min	`ios`	:iphone:`ipa` :calling:

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:x:	96a689cb	#22	2024-11-06 10:02:30	~2 min	`ios`	:page_facing_up:`log`
:heavy_check_mark:	96a689cb	#22	2024-11-06 10:04:25	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	96a689cb	#22	2024-11-06 10:07:18	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	96a689cb	#22	2024-11-06 10:07:41	~7 min	`android-e2e`	:robot:`apk` :calling:
:x:	96a689cb	#23	2024-11-06 10:20:52	~1 min	`ios`	:page_facing_up:`log`
:x:	96a689cb	#24	2024-11-06 13:48:42	~1 min	`ios`	:page_facing_up:`log`

:heavy_check_mark:	471b1c76	#23	2024-11-14 13:27:12	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	471b1c76	#23	2024-11-14 13:29:54	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	471b1c76	#23	2024-11-14 13:30:08	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	471b1c76	#25	2024-11-14 13:31:18	~8 min	`ios`	:iphone:`ipa` :calling:

Aug 22 '24 15:08 status-im-auto

@status-im/mobile-qa ready for testing

Sep 03 '24 12:09 clauxx

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 2
Expected to fail tests: 0
Passed tests: 5

IDs of failed tests: 727231,702843

Failed tests (2)

Click to expand

Rerun failed tests

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

## Creating new multiaccount (password:'qwerty1234', keycard:'False', enable_notification: 'False')
Device 1: Find `Button` by `xpath`: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']`

Test setup failed: critical/test_wallet.py:202: in prepare_devices
    self.sign_in_view.create_user()
../views/sign_in_view.py:241: in create_user
    self.terms_and_privacy_checkbox.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

## Creating new multiaccount (password:'qwerty1234', keycard:'False', enable_notification: 'False')
Device 2: Find Button by xpath: //*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']

Test setup failed: critical/chats/test_public_chat_browsing.py:311: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:241: in create_user
    self.terms_and_privacy_checkbox.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@content-desc='terms-privacy-checkbox-container']/*[@content-desc='checkbox-off']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Passed tests (5)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions

Device 1:

Steps, video, logs

Sep 03 '24 15:09 status-im-auto

@clauxx thanks for the PR. Unfortunately testing of this PR is partially blocked because L2 - L1 transactions are constantly failing in blockchain. It seems to be some third party issue (on hopper side) and I have logged a separate ticket on this https://github.com/status-im/status-mobile/issues/21180 .

At the same time I was able to perform L2-L2 (Arbitrum - Optimism).

So far, I have 1 question: is it expected that we show different values in Recepient gets and within Recepient route element?

Shouldn't we show in both places the final value from Recepient gets?

photo_2024-09-05 13 01 16

Sep 05 '24 10:09 pavloburykh

@clauxx thanks for the PR. Unfortunately testing of this PR is partially blocked because L2 - L1 transactions are constantly failing in blockchain. It seems to be some third party issue (on hopper side) and I have logged a separate ticket on this #21180 .

At the same time I was able to perform L2-L2 (Arbitrum - Optimism).

So far, I have 1 question: is it expected that we show different values in Recepient gets and within Recepient route element?

Shouldn't we show in both places the final value from Recepient gets? ...

@pavloburykh Not sure which way is best, but I understand your UX concern. I used the Hop exchange (which we use as well) as reference and it looks the same there (see screenshot below). I can adjust so both values are the same if needed.

cc: @shivekkhurana @xAlisher

Sep 16 '24 06:09 clauxx

@shivekkhurana @xAlisher can you have a look at the question above please? Not very urgent though, since fully testing this PR is still blocked.

Oct 03 '24 10:10 clauxx

I'll check this PR tomorrow, it seems like we've been unblocked

Oct 08 '24 16:10 VolodLytvynenko

Hi @clauxx Could you please resolve conflicts and rebase the current PR? Thanx

Oct 10 '24 09:10 VolodLytvynenko

https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17541-134301&t=1HJbDbCP3YWf6d0M-1

@shivekkhurana

Oct 10 '24 10:10 xAlisher

@xAlisher just to confirm, the "To" value will be larger than the "Bridged to ..." value

Oct 10 '24 10:10 clauxx

Hi @clauxx Could you please resolve conflicts and rebase the current PR? Thanx

@VolodLytvynenko before re-testing this PR we need to get latest go in mobile, cause we need this fix https://github.com/status-im/status-go/pull/5915 So please, do not start re-testing until go version is bumped in mobile develop (we will need to rebase this PR once again after it is done). I will ping you up once it will be ready.

Oct 10 '24 10:10 pavloburykh

@VolodLytvynenko Also, i'll have to add the new design for the bonder fee, so I'll remove it from testing for now.

Oct 10 '24 10:10 clauxx

@clauxx @pavloburykh, please note that this is just a draft for now. If it works for you, I'll need to get approval from @pedro-et before moving forward.

Oct 10 '24 11:10 xAlisher

@clauxx @pavloburykh, please note that this is just a draft for now. If it works for you, I'll need to get approval from @pedro-et before moving forward.

@clauxx @xAlisher are those UI changes critical for us in terms of 2.31?

The point is that we would like to include current PR into release and we are about to cut release branch soon. Maybe we can proceed with new UI improvement separately in order not to block this PR from testing and merging? WDYT?

cc @churik

Oct 10 '24 11:10 pavloburykh

I'd say it is nice-to-have for 2.31 and would postpone it to the next release, I'd vote for fixing the functional issue first.

Oct 10 '24 15:10 churik

I'd say it is nice-to-have for 2.31 and would postpone it to the next release, I'd vote for fixing the functional issue first.

In that case if there are no issues then, we can merge, right?

Oct 11 '24 09:10 clauxx

@xAlisher are those UI changes critical for us in terms of 2.31?

I do not think it's critical. Anyway design is updated and approved https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Wallet?node-id=17541-134301&t=ZIS94nOLdZlNKOl5-1

Oct 11 '24 10:10 xAlisher

In that case if there are no issues then, we can merge, right?

@clauxx we still need to check L1-L2 bridge. I am waiting for bumping go version in mobile develop. We will ping you up once PR is ready for merge. Thank you.

Oct 11 '24 10:10 pavloburykh

@clauxx sorry, can I ask you to rebase one more time. Status go has been updated in mobile develop and we need those fixes to test the PR. I have tried to rebase myself by there are conflicts that should be resolved.

Oct 11 '24 14:10 pavloburykh

@clauxx sorry, can I ask you to rebase one more time. Status go has been updated in mobile develop and we need those fixes to test the PR. I have tried to rebase myself by there conflicts that should be resolved.

no worries, done 👍

Oct 11 '24 14:10 clauxx

Unfortunately L1-L2 transactions still failing so this issue is valid https://github.com/status-im/status-mobile/issues/21180 and it blocks us from testing L1-L2 bridge in this PR. @churik @shivekkhurana I am not sure what to do with that. It seems to be third party issue, but it blocks us from properly testing this PR. Do you consider we can skip L1-L2 check in order to unblock this PR?

@clauxx At the same time, I see issue related to calculation of Recipient gets value when building L1-L2 routes, please take a look at the issues below.

ISSUE 1 NaN `Recipient gets` value when bridging L1 - L2 Optimism

Steps:

Build routes from L1 to L2 Optimism (I used Eth for testing)
Pay attention at Recipient gets value

Actual result: NaN value

photo_2024-10-11 19 26 11 Status-debug-logs - 2024-10-11T192357.595.zip

https://github.com/user-attachments/assets/0fa3718b-2db2-4d70-a589-0ec3871f46b3

Oct 11 '24 16:10 pavloburykh

ISSUE 2 `Recipient gets` value is larger than `To` value when bridging L1 - L2 Arbitrum

@clauxx this one is reproducible in develop as well. I guess it would be nice to handle it in scope of this PR. WDYT?

Steps:

Built L1 - L2 Arbitrum route (I used Eth for testing)
Compare To and Recipient gets values

Actual result: Recipient gets is larger than To value

Status-debug-logs - 2024-10-11T193530.378.zip

photo_2024-10-11 19 35 58

Oct 11 '24 16:10 pavloburykh

@briansztamfater @ulisesmac @shivekkhurana please have another look, as there are a few new changes in this PR since you last reviewed it.

Oct 23 '24 09:10 clauxx

@clauxx

Added a reply to some comments, but everything still looks fine :+1: Thanks for the PR!

Oct 24 '24 00:10 ulisesmac

@pavloburykh ready to be QA'd again :+1:

Oct 24 '24 08:10 clauxx

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7

IDs of failed tests: 702843

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
Device 2: Wait for element `Button` for max 120s and click when it is available

Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:420: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Passed tests (7)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions

Device 1:

Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Oct 24 '24 08:10 status-im-auto

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 2
Expected to fail tests: 0
Passed tests: 6

IDs of failed tests: 703133,702843

Failed tests (2)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]`
Device 2: Wait for element `Button` for max 120s and click when it is available

Test setup failed: critical/chats/test_public_chat_browsing.py:350: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:420: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find Button by accessibility id: show-profiles
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:244: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:192: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!

Device sessions

Device 1:

Steps, video, logs

Passed tests (6)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

Oct 24 '24 09:10 status-im-auto

@pavloburykh ready to be QA'd again 👍

Thank you for the fix @clauxx! The release 2.31 scope is already overloaded, and we don’t want to extend the testing time, so we've decided to move the PR to the next release 2.32. We will get back to testing this PR once we finish with release 2.31 testing.

Oct 28 '24 09:10 pavloburykh

@pavloburykh yeah makes sense :+1:. LMK when you'll be able to pick it up afterwards

Oct 28 '24 11:10 clauxx

@clauxx thanks for the PR! ISSUES 1 and 2 are fixed. Please take a look at the new issues:

ISSUE 3 `cannot unmarshal hex string without 0x prefix...` in case of L1 - L2 (Arb) transaction

Steps:

Initiate L1 - L2 (Arb) transaction
Confirm transaction
Observe the error

Actual result: cannot unmarshal hex string without 0x prefix... error

Status-debug-logs - 2024-11-01T140435.945.zip

photo_2024-11-01 14 04 51

https://github.com/user-attachments/assets/07d614cb-456b-4d02-99f1-ba6eac18da1a

Nov 01 '24 12:11 pavloburykh

status-mobile status-mobile copied to clipboard

Fix send no bonder fee included

Summary

Platforms

Areas that maybe impacted

Functional

Jenkins Builds

71% of end-end tests have passed

Failed tests (2)

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Passed tests (5)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

ISSUE 1 NaN Recipient gets value when bridging L1 - L2 Optimism

ISSUE 2 Recipient gets value is larger than To value when bridging L1 - L2 Arbitrum

88% of end-end tests have passed

Failed tests (1)

Class TestCommunityMultipleDeviceMerged:

Passed tests (7)

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

75% of end-end tests have passed

Failed tests (2)

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Passed tests (6)

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

ISSUE 3 cannot unmarshal hex string without 0x prefix... in case of L1 - L2 (Arb) transaction

status-mobile
status-mobile copied to clipboard

ISSUE 1 NaN `Recipient gets` value when bridging L1 - L2 Optimism

ISSUE 2 `Recipient gets` value is larger than `To` value when bridging L1 - L2 Arbitrum

ISSUE 3 `cannot unmarshal hex string without 0x prefix...` in case of L1 - L2 (Arb) transaction