status-mobile fixed overlapping last message by the composer when there is a pinned…

fixes https://github.com/status-im/status-mobile/issues/20513

Summary

This pr adds margin-bottom when the user is not allowed to post a message in a community channel because they are not a member. The margin-bottom is the height of the permission bottom sheet that is shown when the user is no longer a community member

A note to @status-im/mobile-qa, this pr also fixes a bug explained in this comment https://github.com/status-im/status-mobile/pull/20606#issuecomment-2245086356. Its a small simple fix I bundled up in this pr

Before and after screenshots comparison

status: ready

Jul 01 '24 10:07 jo-mut

Jenkins Builds

Click to see older builds (76)

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:x:	79f3b31542669e3d492b891b3d1236bf68e16377	#1	2024-07-01 11:04:01	~5 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	79f3b31542669e3d492b891b3d1236bf68e16377	#1	2024-07-01 11:07:32	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	79f3b31542669e3d492b891b3d1236bf68e16377	#1	2024-07-01 11:10:07	~11 min	`ios`	:iphone:`ipa` :calling:
:heavy_check_mark:	79f3b31542669e3d492b891b3d1236bf68e16377	#1	2024-07-01 11:10:57	~12 min	`android-e2e`	:robot:`apk` :calling:

:heavy_check_mark:	e37afa0a559af3e44195d35c5872dc9ec28f1333	#2	2024-07-01 11:51:02	~7 min	`tests`	:page_facing_up:`log`
:x:	e37afa0a559af3e44195d35c5872dc9ec28f1333	#2	2024-07-01 11:51:43	~8 min	`ios`	:page_facing_up:`log`
:heavy_check_mark:	e37afa0a559af3e44195d35c5872dc9ec28f1333	#2	2024-07-01 11:53:43	~10 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	e37afa0a559af3e44195d35c5872dc9ec28f1333	#2	2024-07-01 11:55:13	~11 min	`android-e2e`	:robot:`apk` :calling:

:x:	ea97a4f6	#3	2024-07-16 10:38:43	~2 min	`ios`	:page_facing_up:`log`
:heavy_check_mark:	ea97a4f6	#3	2024-07-16 10:41:00	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	ea97a4f6	#3	2024-07-16 10:42:15	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	ea97a4f6	#3	2024-07-16 10:43:59	~7 min	`android`	:robot:`apk` :calling:

:heavy_check_mark:	605355a1	#4	2024-07-18 10:43:01	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	605355a1	#4	2024-07-18 10:44:32	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	605355a1	#4	2024-07-18 10:46:17	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	605355a1	#4	2024-07-18 10:47:47	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	d5e25971	#5	2024-07-18 22:14:49	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	d5e25971	#5	2024-07-18 22:16:55	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	d5e25971	#5	2024-07-18 22:17:51	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	d5e25971	#5	2024-07-18 22:19:30	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	d9feecc0	#7	2024-07-18 23:01:39	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	d9feecc0	#7	2024-07-18 23:04:53	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	d9feecc0	#7	2024-07-18 23:05:07	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	d9feecc0	#7	2024-07-18 23:06:44	~9 min	`ios`	:iphone:`ipa` :calling:

:x:	d5258da6	#8	2024-07-19 15:19:41	~3 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	d5258da6	#8	2024-07-19 15:23:00	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	d5258da6	#8	2024-07-19 15:24:35	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	d5258da6	#8	2024-07-19 15:25:44	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	d6096ec6	#9	2024-07-19 16:16:57	~5 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	d6096ec6	#9	2024-07-19 16:17:49	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	d6096ec6	#9	2024-07-19 16:19:34	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	d6096ec6	#9	2024-07-19 16:20:49	~9 min	`ios`	:iphone:`ipa` :calling:

:x:	ca53173d	#10	2024-07-23 22:56:20	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	ca53173d	#10	2024-07-23 22:58:18	~6 min	`android-e2e`	:robot:`apk` :calling:

:x:	42c72d16	#12	2024-07-23 23:04:25	~3 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	42c72d16	#12	2024-07-23 23:07:58	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	42c72d16	#12	2024-07-23 23:08:49	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	42c72d16	#12	2024-07-23 23:10:04	~8 min	`ios`	:iphone:`ipa` :calling:

:x:	c920bac7	#13	2024-07-24 11:59:46	~2 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	c920bac7	#13	2024-07-24 12:03:27	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	c920bac7	#13	2024-07-24 12:03:38	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	c920bac7	#13	2024-07-24 12:07:06	~10 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	3b3d9c91	#14	2024-07-24 12:46:56	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	3b3d9c91	#14	2024-07-24 12:49:08	~6 min	`android-e2e`	:robot:`apk` :calling:

:heavy_check_mark:	b753ce9f	#15	2024-07-24 12:53:35	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	b753ce9f	#15	2024-07-24 12:55:45	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	b753ce9f	#15	2024-07-24 12:55:58	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	b753ce9f	#15	2024-07-24 12:58:28	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	d46a9bb8	#16	2024-07-24 19:27:56	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	d46a9bb8	#16	2024-07-24 19:29:45	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	d46a9bb8	#16	2024-07-24 19:30:14	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	d46a9bb8	#16	2024-07-24 19:32:45	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	34555e4c	#17	2024-07-26 09:55:17	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	34555e4c	#17	2024-07-26 09:56:57	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	34555e4c	#17	2024-07-26 09:59:09	~8 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	34555e4c	#17	2024-07-26 10:01:41	~11 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	79fcb12d	#18	2024-07-26 18:29:59	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	79fcb12d	#18	2024-07-26 18:32:56	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	79fcb12d	#18	2024-07-26 18:32:58	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	79fcb12d	#18	2024-07-26 18:34:28	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	3261ac05	#19	2024-07-26 19:19:29	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	3261ac05	#19	2024-07-26 19:21:51	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	3261ac05	#19	2024-07-26 19:22:47	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	3261ac05	#19	2024-07-26 19:24:06	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	ced05069	#20	2024-07-29 08:36:20	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	ced05069	#20	2024-07-29 08:38:28	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	ced05069	#20	2024-07-29 08:39:07	~7 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	ced05069	#20	2024-07-29 08:40:38	~8 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	df32b171	#21	2024-08-19 09:08:05	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	df32b171	#21	2024-08-19 09:10:01	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	df32b171	#21	2024-08-19 09:10:56	~7 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	df32b171	#21	2024-08-19 09:12:56	~9 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	92c38762	#22	2024-09-05 08:24:25	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	92c38762	#22	2024-09-05 08:25:55	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	92c38762	#22	2024-09-05 08:27:36	~8 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	92c38762	#22	2024-09-05 08:33:01	~13 min	`ios`	:iphone:`ipa` :calling:

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_check_mark:	9f9a5aff	#23	2024-09-09 22:52:40	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	9f9a5aff	#23	2024-09-09 22:54:39	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	9f9a5aff	#23	2024-09-09 22:55:16	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	9f9a5aff	#23	2024-09-09 22:59:02	~10 min	`ios`	:iphone:`ipa` :calling:

:heavy_check_mark:	6c4900ed	#24	2024-09-09 23:06:48	~4 min	`tests`	:page_facing_up:`log`
:heavy_check_mark:	6c4900ed	#24	2024-09-09 23:08:46	~6 min	`android-e2e`	:robot:`apk` :calling:
:heavy_check_mark:	6c4900ed	#24	2024-09-09 23:09:13	~6 min	`android`	:robot:`apk` :calling:
:heavy_check_mark:	6c4900ed	#24	2024-09-09 23:12:33	~10 min	`ios`	:iphone:`ipa` :calling:

Jul 01 '24 11:07 status-im-auto

@ilmotta I have made some updates on this, so instead of checking on pinned messages, we instead check on if the user can post to community and if its a community chat.

https://github.com/user-attachments/assets/5d985618-6ba2-4f29-843d-3f65d403cca5

Jul 19 '24 15:07 jo-mut

@ilmotta something else I am noticing, if there is a pinned message and the message is unpinned, the app is killed and restarted and navigate to the current chat the message is still pinned.

this behavior is inconsistent maybe its because i was using an old account or something. I am not reproducing it any more

Jul 19 '24 15:07 jo-mut

I have made some updates on this, so instead of checking on pinned messages, we instead check on if the user can post to community and if its a community chat.

Thanks @jo-mut. I'll check the PR again later today.

something else I am noticing, if there is a pinned message and the message is unpinned, the app is killed and restarted and navigate to the current chat the message is still pinned.

There's a delay for messages to propagate in the network. Maybe because of that, when you unpin and immediately close the app, when reopening, the deletion may not have fully propagated yet?

Or do you mean you reopen and the message is never unpinned?

Jul 19 '24 16:07 ilmotta

I am also closing the following issue https://github.com/status-im/status-mobile/issues/20779, I think its because was using an old account.

Jul 19 '24 16:07 jo-mut

I have made some updates on this, so instead of checking on pinned messages, we instead check on if the user can post to community and if its a community chat.

Thanks @jo-mut. I'll check the PR again later today.

something else I am noticing, if there is a pinned message and the message is unpinned, the app is killed and restarted and navigate to the current chat the message is still pinned.

There's a delay for messages to propagate in the network. Maybe because of that, when you unpin and immediately close the app, when reopening, the deletion may not have fully propagated yet?

Or do you mean you reopen and the message is never unpinned?

yeah, when I pin and unpin a message and restart the app, the message is still pinned but not its not reproducible, so maybe its because of message reliablity issues or could because i was using an old account in testing

Jul 19 '24 16:07 jo-mut

@ilmotta this is what I meant before, when there is a pinned message and its unpinned, on-reopening the community channel the message is still pinned and when the message is not pinned and I pin the message on-reopening the channel the message in not pinned. The behaviour is the opposite when the channel is closed and reopened. It could be message reliability

https://github.com/user-attachments/assets/4c890944-648f-49d8-ae98-d67b11f279cb

https://github.com/user-attachments/assets/8983523f-0e9f-4e68-b97e-c96082e637e3

Jul 23 '24 09:07 jo-mut

The referenced issue does not seem to happen because of a pinned message. It still happens in the case where there is not a pinned message and the user is not a community member and therefore cannot post.

As tested on develop user is member v user has left community

Jul 23 '24 09:07 jo-mut

this is what I meant before, when there is a pinned message and its unpinned, on-reopening the community channel the message is still pinned and when the message is not pinned and I pin the message on-reopening the channel the message in not pinned. The behaviour is the opposite when the channel is closed and reopened. It could be message reliability

@jo-mut, in this example, I think the user can't unpin a message if they are not a member, that's why you see the message is still unpinned. If they could, anybody would be able to alter the list of pinned messages.

The actual bug is that the user shouldn't be able to pin/unpin messages if they are not a member. This we should fix if possible.

Jul 23 '24 12:07 ilmotta

@ilmotta got you, I think that can be handled in a separate issues, it falls out of scope for this issue. As for this pr, the overlapping of the last-message is fixed

Jul 23 '24 12:07 jo-mut

The actual bug is that the user shouldn't be able to pin/unpin messages if they are not a member. This we should fix if possible.

shall I create an issue or have you already done so? I think we can do this one in this release

Jul 23 '24 12:07 jo-mut

this is what I meant before, when there is a pinned message and its unpinned, on-reopening the community channel the message is still pinned and when the message is not pinned and I pin the message on-reopening the channel the message in not pinned. The behaviour is the opposite when the channel is closed and reopened. It could be message reliability

@jo-mut, in this example, I think the user can't unpin a message if they are not a member, that's why you see the message is still unpinned. If they could, anybody would be able to alter the list of pinned messages.

The actual bug is that the user shouldn't be able to pin/unpin messages if they are not a member. This we should fix if possible.

@ilmotta I added a commit to prevent a user who is not a member from pinning and un-pinning channel messages, I thinks its a small issue that can be bundled up in this pr. Once approved I will let the QA know so they can take this into account when testing.

Jul 23 '24 22:07 jo-mut

Thank you @jo-mut, for sure the fix could have been implemented in a separate PR, but thanks for helping with that already. And sorry today I was on many calls and couldn't check the PR again.

Jul 24 '24 01:07 ilmotta

@ilmotta I made last minute changes to check if user is a community member instead of using able-to-send-message?

Jul 24 '24 19:07 jo-mut

57% of end-end tests have passed

Total executed tests: 7
Failed tests: 2
Expected to fail tests: 1
Passed tests: 4

IDs of failed tests: 702745,727229

IDs of expected to fail tests: 727232

Failed tests (2)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
Device 2: `Text` is `0.01539 ETH`

critical/test_wallet.py:156: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4822 but expected to be 0.4823

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Tap on found: Button
Device 2: Attempt 0 is successful clicking close-activity-center

Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:409: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:162: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:159: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:163: in wait_for_rendering_ended_and_click
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by xpath:`//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find EditBox by accessibility id: add-address-to-watch
Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com/status-im/status-mobile/issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (4)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions

Device 1:

Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

Device sessions

Device 1:

Steps, video, logs

Jul 24 '24 19:07 status-im-auto

@ilmotta I made last minute changes to check if user is a community member instead of using able-to-send-message?

Thanks @jo-mut. Let's also see the feedback from a QA about this point. I don't know the granularity at which pinning messages are controllable. Double-checking how the desktop app behaves is another sure way to verify how it should be or pinging a desktop dev. Being a community member may be correct, but might be too permissive too and still not the precise check we should do because the user is doing an operation at the channel level, not community level.

Jul 25 '24 00:07 ilmotta

53% of end-end tests have passed

Total executed tests: 51
Failed tests: 23
Expected to fail tests: 1
Passed tests: 27

IDs of failed tests: 702845,702840,702894,703086,702947,702958,702775,702786,702844,704613,702841,702839,702809,702838,704615,702948,702859,703629,702957,702843,727229,702777,703194

IDs of expected to fail tests: 727232

Failed tests (23)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

Device 2: Swiping right on element Button
Device 2: Find `Button` by `xpath`: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]`

Test setup failed: activity_center/test_activity_center.py:274: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
Device 2: Text is 0.01619 ETH

critical/test_wallet.py:156: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4813 but expected to be 0.4814

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775

Device 1: Waiting 35s for dapp to load
Device 1: Find Text by accessibility id: community-title

critical/test_deep_and_universal_links.py:112: in test_links_deep_links
    if self.community_view.community_title.text != text:
../views/base_element.py:419: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by accessibility id: `community-title` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

2. test_links_open_universal_links_from_chat, id: 704613

Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/ixyACjgKDVNOVCBjb21tdW5pdHkSHHJlcXVpcmUgMTAgU05UIEdvZXJsaSB0byB1c2UYASIHI2VhYjcwMAM=#zQ3shUeGnhM33QW4g9JfYfeLFAH9ZwbDboNYn5exCR7S3ii1y')]
Device 1: Find Text by accessibility id: community-title

critical/test_deep_and_universal_links.py:64: in test_links_open_universal_links_from_chat
    if self.community_view.community_title.text != text:
../views/base_element.py:419: in text
    text = self.find_element().text
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Text by accessibility id: `community-title` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958

Test setup failed: activity_center/test_activity_center.py:414: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

2. test_activity_center_mentions, id: 702957

Device 2: Swiping right on element Button
Device 2: Find Button by xpath: (//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]

Test setup failed: activity_center/test_activity_center.py:414: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

2. test_community_contact_block_unblock_offline, id: 702894

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

3. test_community_mark_all_messages_as_read, id: 703086

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

5. test_community_unread_messages_badge, id: 702841

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

6. test_community_message_delete, id: 702839

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

7. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Swiping right on element Button
Device 2: Find Button by xpath: (//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

8. test_community_edit_delete_message_when_offline, id: 704615

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

9. test_community_one_image_send_reply, id: 702859

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

10. test_community_message_edit, id: 702843

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

11. test_community_several_images_send_reply, id: 703194

Test setup failed: critical/chats/test_public_chat_browsing.py:349: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845

Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

2. test_community_mentions_push_notification, id: 702786

Device 2: Swiping right on element Button
Device 2: Find Button by xpath: (//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]

Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

3. test_community_markdown_support, id: 702809

Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

4. test_community_hashtag_links_to_community_channels, id: 702948

Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

5. test_community_join_when_node_owner_offline, id: 703629

Test setup failed: critical/chats/test_public_chat_browsing.py:869: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:421: in join_community
    self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 2: Button by xpath: `(//*[@resource-id='slide-button-track']//*[@content-desc='icon'])[1]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 1: Find Button by accessibility id: enable-notifications-later-button
Device 1: Find Button by accessibility id: welcome-button

activity_center/test_activity_center.py:176: in test_add_contact_field_validation
    self.loop.run_until_complete(run_in_parallel(((_device_1_creates_user, {}),
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
activity_center/test_activity_center.py:167: in _device_1_creates_user
    self.device_1.create_user(username=new_username_1)
../views/sign_in_view.py:268: in create_user
    self.start_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `welcome-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception; also Unexpected Alert is shown: 'Please shake the phone to report this error and restart the app. multiaccount is currently empty, which means something went wrong when trying to update it with'

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find EditBox by accessibility id: add-address-to-watch
Device 1: Type 0x8d2413447ff297d30bdc475f6d5cb00254685aae to EditBox

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element

[[Missing networks in account address, https://github.com/status-im/status-mobile/issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Passed tests (27)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

2. test_1_1_chat_message_reaction, id: 702730

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

4. test_1_1_chat_pin_messages, id: 702731

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

5. test_1_1_chat_text_message_delete_push_disappear, id: 702733

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

6. test_1_1_chat_push_emoji, id: 702813

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

8. test_1_1_chat_send_image_save_and_share, id: 703391

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

3. test_1_1_chat_delete_via_long_press_relogin, id: 702784

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

2. test_community_navigate_to_channel_when_relaunch, id: 702846

Device sessions

Device 1:

Steps, video, logs

3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions

Device 1:

Steps, video, logs

4. test_community_undo_delete_message, id: 702869

Device sessions

Device 1:

Steps, video, logs

5. test_community_mute_community_and_channel, id: 703382

Device sessions

Device 1:

Steps, video, logs

6. test_community_discovery, id: 703503

Device sessions

Device 1:

Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

Device sessions

Device 1:

Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

2. test_group_chat_join_send_text_messages_push, id: 702807

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

3. test_group_chat_offline_pn, id: 702808

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

4. test_group_chat_pin_messages, id: 702732

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

5. test_group_chat_send_image_save_and_share, id: 703297

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

6. test_group_chat_mute_chat, id: 703495

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

2. test_activity_center_contact_request_decline, id: 702850

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Jul 25 '24 10:07 status-im-auto

Hi @ilmotta !

This PR touches some areas needed to be retested. Sorry for the delay.

want to report that @jo-mut fix of overlapping is good and I see no issue on my iOS
pin logic that exist on mobile and desktop:

no one can NOT pin/un-pin if he is NOT a community member
no one can NOT pin/un-pin if he IS a member but NO such desktop setting is turned on during community creation on desktop:

also desktop has such permissions that could be added to channels:

View
View and post

and it is the way for user to be a member but NOT to have ability to post (so NOT being able to send a message)

But this functionality should be retested as there are issues in token gated functionality and I can not clearly say will this View only member can pin/unpin in such case.

Aug 19 '24 14:08 mariia-skrypnyk

@ilmotta will leave this PR in Testing status until 2.31 if you do not mind as we are not planning to include it in 2.30

Aug 19 '24 14:08 mariia-skrypnyk

100% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 0
Passed tests: 7

Passed tests (7)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

Device sessions

Device 1:

Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions

Device 1:

Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

2. test_wallet_send_eth, id: 727229

Aug 19 '24 14:08 status-im-auto

@ilmotta will leave this PR in Testing status until 2.31 if you do not mind as we are not planning to include it in 2.30

Agreed @mariia-skrypnyk. Better that way 👍🏼

Aug 19 '24 16:08 ilmotta

also better to mind composer simlification, might be also affected https://github.com/status-im/status-mobile/pull/20125

Aug 26 '24 12:08 churik

So should we just close this PR for now?

@ilmotta @churik

Sep 03 '24 07:09 mariia-skrypnyk

So should we just close this PR for now?

It depends if the work in this PR is mostly done, if it is, we can just update/rebase and QA it. @mariia-skrypnyk You mentioned before I see no issue on my iOS, so if it works on Android we could merge the PR. The issues around token-gating functionality I think are outside the scope of this PR, which is supposed to be just UI polish.

Sep 03 '24 11:09 ilmotta

I agree that in general pin logic is outside of scope of the PR; we can merge if initial bug is fixed and move pin logic issues to separate , cc @mariia-skrypnyk

Sep 03 '24 14:09 churik

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 1
Expected to fail tests: 0
Passed tests: 6

IDs of failed tests: 727230

Failed tests (1)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230

Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`

critical/test_wallet.py:164: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:47: in _get_balances_before_tx
    eth_amount_receiver = self.wallet_2.get_asset(asset_name='Ether').get_amount()
../views/wallet_view.py:24: in get_amount
    amount = element.text.split()[0]
../views/base_element.py:419: in text
    text = self.find_element().text
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:90: in text
    return self._execute(Command.GET_ELEMENT_TEXT)["value"]
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
    return self._parent.execute(command, params)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 The element 'By.xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]' does not exist in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
E   Stacktrace:
E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]' does not exist in DOM anymore
E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:117)
E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
E   	at io.appium.uiautomator2.handler.GetText.safeHandle(GetText.java:20)
E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
E   	at java.lang.Thread.run(Thread.java:1012)

Passed tests (6)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device sessions

Device 1:

Steps, video, logs

2. test_community_copy_and_paste_message_in_chat_input, id: 702742

Device sessions

Device 1:

Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

Device sessions

Device 1:

Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_eth, id: 727229

Sep 05 '24 10:09 status-im-auto

Hi @ilmotta @ulisesmac !

Rebased PR and retested on iOS and Android. Issue with overlapping is fixed and PR can be merged. Failed e2e is not related.

Sep 05 '24 10:09 mariia-skrypnyk

status-mobile status-mobile copied to clipboard

fixed overlapping last message by the composer when there is a pinned…

Summary

Before and after screenshots comparison

Jenkins Builds

57% of end-end tests have passed

Failed tests (2)

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (4)

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

53% of end-end tests have passed

Failed tests (23)

Class TestActivityMultipleDevicePR:

Class TestWalletMultipleDevice:

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Expected to fail tests (1)

Class TestWalletOneDevice:

Passed tests (27)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

100% of end-end tests have passed

Passed tests (7)

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

86% of end-end tests have passed

Failed tests (1)

Class TestWalletMultipleDevice:

Passed tests (6)

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestWalletMultipleDevice:

status-mobile
status-mobile copied to clipboard