status-mobile
status-mobile copied to clipboard
[#19921] feat: remove key pair action
fixes #19921
Summary
Implement the remove key-pair feature for the wallet settings.
Areas that maybe impacted
- Keypairs and account screen
- Remove key pair
Steps to test
- Open Wallet setting
- Click on not default keypair's action button
- Click on remove key pair
Result
status: wip
Jenkins Builds
Click to see older builds (31)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | 300edb08e4758f073430515da27771c9d5a0dc67 | #1 | 2024-05-13 17:37:21 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 300edb08e4758f073430515da27771c9d5a0dc67 | #1 | 2024-05-13 17:41:09 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 300edb08e4758f073430515da27771c9d5a0dc67 | #1 | 2024-05-13 17:41:52 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 300edb08e4758f073430515da27771c9d5a0dc67 | #1 | 2024-05-13 17:44:28 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 2003e5b5ed9dfb4253a23e9889c714db5af974ae | #2 | 2024-05-14 16:58:28 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 2003e5b5ed9dfb4253a23e9889c714db5af974ae | #2 | 2024-05-14 16:59:56 | ~5 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 2003e5b5ed9dfb4253a23e9889c714db5af974ae | #2 | 2024-05-14 17:01:06 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 2003e5b5ed9dfb4253a23e9889c714db5af974ae | #2 | 2024-05-14 17:02:54 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 3f7b94c9db971f7e860e9ce6663bec1b434b3f66 | #3 | 2024-05-15 05:19:32 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 3f7b94c9db971f7e860e9ce6663bec1b434b3f66 | #3 | 2024-05-15 05:23:10 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 3f7b94c9db971f7e860e9ce6663bec1b434b3f66 | #3 | 2024-05-15 05:24:17 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 3f7b94c9db971f7e860e9ce6663bec1b434b3f66 | #3 | 2024-05-15 05:26:32 | ~10 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 2d301da4bbb12a0567105ddac532f834fb8c5ccd | #4 | 2024-05-23 12:38:52 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 2d301da4bbb12a0567105ddac532f834fb8c5ccd | #4 | 2024-05-23 12:40:49 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 2d301da4bbb12a0567105ddac532f834fb8c5ccd | #4 | 2024-05-23 12:41:47 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 2d301da4bbb12a0567105ddac532f834fb8c5ccd | #4 | 2024-05-23 12:44:18 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 4e02be3d2707ec40974e65ce435139ef8e23ce5b | #5 | 2024-05-23 15:43:19 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 4e02be3d2707ec40974e65ce435139ef8e23ce5b | #5 | 2024-05-23 15:46:13 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 4e02be3d2707ec40974e65ce435139ef8e23ce5b | #5 | 2024-05-23 15:46:22 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 4e02be3d2707ec40974e65ce435139ef8e23ce5b | #5 | 2024-05-23 15:48:35 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 6d92fad1d548eb3910bc07b18753f87b041d1228 | #6 | 2024-05-24 12:22:56 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 6d92fad1d548eb3910bc07b18753f87b041d1228 | #6 | 2024-05-24 12:23:15 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 6d92fad1d548eb3910bc07b18753f87b041d1228 | #6 | 2024-05-24 12:27:33 | ~10 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 9235cebb4edbe8b468a8ef96b5c19d05e551a475 | #8 | 2024-05-24 14:44:05 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 9235cebb4edbe8b468a8ef96b5c19d05e551a475 | #8 | 2024-05-24 14:46:00 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 9235cebb4edbe8b468a8ef96b5c19d05e551a475 | #8 | 2024-05-24 14:46:08 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 9235cebb4edbe8b468a8ef96b5c19d05e551a475 | #8 | 2024-05-24 14:49:44 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | a5609440858611017a452e6cfb1c74966e212425 | #9 | 2024-05-24 16:21:55 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | a5609440858611017a452e6cfb1c74966e212425 | #9 | 2024-05-24 16:24:22 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | a5609440858611017a452e6cfb1c74966e212425 | #9 | 2024-05-24 16:26:53 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | a5609440858611017a452e6cfb1c74966e212425 | #9 | 2024-05-24 16:31:24 | ~13 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 8b6861e9ffcf6818f23642267aafc15f180671a4 | #10 | 2024-05-27 12:12:13 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 8b6861e9ffcf6818f23642267aafc15f180671a4 | #10 | 2024-05-27 12:13:01 | ~6 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 8b6861e9ffcf6818f23642267aafc15f180671a4 | #10 | 2024-05-27 12:15:06 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 8b6861e9ffcf6818f23642267aafc15f180671a4 | #10 | 2024-05-27 12:20:15 | ~14 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 7a87cb45480cd2bcf72d56351658f446215c2f89 | #11 | 2024-05-27 12:46:10 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 7a87cb45480cd2bcf72d56351658f446215c2f89 | #11 | 2024-05-27 12:48:25 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 7a87cb45480cd2bcf72d56351658f446215c2f89 | #11 | 2024-05-27 12:49:19 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 7a87cb45480cd2bcf72d56351658f446215c2f89 | #11 | 2024-05-27 12:55:10 | ~13 min | ios |
:iphone:ipa :calling: |
blocked by this issue https://github.com/status-im/status-mobile/issues/19472, when i want to remove a key pair it throws error no key for given address or file.
will re-test after https://github.com/status-im/status-mobile/pull/19531
@mohsen-ghafouri One thing I noticed is that the removed-keypair toast should be in light mode 🌤️
@seanstrom good catch, I noticed they removed theme from toast's props. resolved.
60% of end-end tests have passed
Total executed tests: 52
Failed tests: 20
Expected to fail tests: 1
Passed tests: 31
IDs of failed tests: 727230,702809,702733,702784,702732,702840,703495,702948,702783,703297,704615,727229,703496,703202,702786,702807,702808,727232,702845,703629
IDs of expected to fail tests: 703503
Failed tests (20)
Click to expand
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
|
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
|
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
|
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
|
| 3. test_community_mentions_push_notification, id: 702786 |
Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
|
| 5. test_community_join_when_node_owner_offline, id: 703629 |
|
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_watch_only_account, id: 727232 |
Device 1: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
|
| 2. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] |
| 3. test_group_chat_send_image_save_and_share, id: 703297 |
|
| 4. test_group_chat_reactions, id: 703202 |
|
| 5. test_group_chat_join_send_text_messages_push, id: 702807 |
[[Issue with a message status - Sent instead of Delivered, https://github.com/status-im/status-mobile/issues/20126]] Device 1: Device 2: Device 3: |
| 6. test_group_chat_offline_pn, id: 702808 |
|
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_emoji_send_copy_paste_reply, id: 702840 |
Device 1: Device 2: |
| 2. test_community_edit_delete_message_when_offline, id: 704615 |
Device 1: Device 2: |
Expected to fail tests (1)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (31)
Click to expand
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
| Device sessions Device 1: |
| 2. test_links_deep_links, id: 702775 |
| Device sessions Device 1: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 4. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 5. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 6. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 9. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
87% of end-end tests have passed
Total executed tests: 52
Failed tests: 4
Expected to fail tests: 3
Passed tests: 45
IDs of failed tests: 727230,727229,702808,727232
IDs of expected to fail tests: 703495,703503,702807
Failed tests (4)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_offline_pn, id: 702808 |
Device 1: Device 2: Device 3: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_watch_only_account, id: 727232 |
Device 1: |
Expected to fail tests (3)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
| 2. test_group_chat_join_send_text_messages_push, id: 702807 |
[[Issue with a message status - Sent instead of Delivered, https://github.com/status-im/status-mobile/issues/20126]] Device 1: Device 2: Device 3: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (45)
Click to expand
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
| Device sessions Device 1: |
| 2. test_links_deep_links, id: 702775 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
@status-im/mobile-qa could you please check the test results? I skip manual QA as this action is still behind the feature flag
@mohsen-ghafouri sorry for delay, ready to go