status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Published 20 hours ago • verified publisher icon status-im

Connected dApps: make right side of page-nav accomodate whatever we need

Open alwx opened this issue 1 year ago • 5 comments

fixes https://github.com/status-im/status-mobile/issues/19867

Summary

Updates page-nav to make it possible to accomodate different types of content on the right side of it — in this paticular case it means mixing account-switcher and regular buttons but the possible options are endless.

Also adds a button to open connected dapps screen + opens a very basic screen with just "Connected dApps" title. The rest will be handled in this issue: https://github.com/status-im/status-mobile/issues/19839 (all that is hidden behind the wallet-connect feature flag)

Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions
  • dapps / app browsing

status: ready

alwx avatar May 08 '24 07:05 alwx

Jenkins Builds

Click to see older builds (22)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 3714fde42c6e76152c2ac09daa316627608313ce #1 2024-05-08 07:24:43 ~4 min tests :page_facing_up:log
:heavy_check_mark: 3714fde42c6e76152c2ac09daa316627608313ce #1 2024-05-08 07:26:12 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: 3714fde42c6e76152c2ac09daa316627608313ce #1 2024-05-08 07:27:37 ~7 min android :robot:apk :calling:
:heavy_check_mark: 3714fde42c6e76152c2ac09daa316627608313ce #1 2024-05-08 07:29:03 ~8 min ios :iphone:ipa :calling:
:x: 31409e67fbf3857e1b211978afd27743c35d04fc #3 2024-05-08 09:29:56 ~3 min tests :page_facing_up:log
:heavy_check_mark: 31409e67fbf3857e1b211978afd27743c35d04fc #3 2024-05-08 09:33:23 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 31409e67fbf3857e1b211978afd27743c35d04fc #3 2024-05-08 09:33:50 ~7 min android :robot:apk :calling:
:heavy_check_mark: 31409e67fbf3857e1b211978afd27743c35d04fc #3 2024-05-08 09:35:44 ~8 min ios :iphone:ipa :calling:
:x: d92f3986ff8eb14dec29fa001f5026df3ba8595a #4 2024-05-08 09:53:17 ~3 min tests :page_facing_up:log
:heavy_check_mark: d92f3986ff8eb14dec29fa001f5026df3ba8595a #4 2024-05-08 09:57:51 ~8 min android :robot:apk :calling:
:heavy_check_mark: d92f3986ff8eb14dec29fa001f5026df3ba8595a #4 2024-05-08 09:57:51 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: d92f3986ff8eb14dec29fa001f5026df3ba8595a #4 2024-05-08 09:58:16 ~8 min ios :iphone:ipa :calling:
:x: 1ead687d26c6555cca62aa5f7e8b8fd3b1f17c7d #6 2024-05-08 11:21:54 ~2 min tests :page_facing_up:log
:x: 6dd8a844612206385c7fc7b9ebebe19329a5e4e7 #7 2024-05-08 11:26:16 ~2 min tests :page_facing_up:log
:x: 5dcaf5b1b5bc0b5a2c35d6c44709db5f2e329cdb #8 2024-05-08 11:30:32 ~3 min tests :page_facing_up:log
:heavy_check_mark: 5dcaf5b1b5bc0b5a2c35d6c44709db5f2e329cdb #8 2024-05-08 11:34:05 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5dcaf5b1b5bc0b5a2c35d6c44709db5f2e329cdb #8 2024-05-08 11:34:13 ~6 min android :robot:apk :calling:
:heavy_check_mark: 5dcaf5b1b5bc0b5a2c35d6c44709db5f2e329cdb #8 2024-05-08 11:35:41 ~8 min ios :iphone:ipa :calling:
:x: f141b3cb9a4b74b2383aa87a11d261ce6ee1c761 #9 2024-05-08 12:07:16 ~3 min tests :page_facing_up:log
:heavy_check_mark: f141b3cb9a4b74b2383aa87a11d261ce6ee1c761 #9 2024-05-08 12:09:36 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: f141b3cb9a4b74b2383aa87a11d261ce6ee1c761 #9 2024-05-08 12:11:05 ~7 min android :robot:apk :calling:
:heavy_check_mark: f141b3cb9a4b74b2383aa87a11d261ce6ee1c761 #9 2024-05-08 12:13:57 ~10 min ios :iphone:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 6a6327ad630a4a9d01853305eec06238771eedba #10 2024-05-08 12:49:12 ~4 min tests :page_facing_up:log
:heavy_check_mark: 6a6327ad630a4a9d01853305eec06238771eedba #10 2024-05-08 12:51:02 ~5 min android :robot:apk :calling:
:heavy_check_mark: 6a6327ad630a4a9d01853305eec06238771eedba #10 2024-05-08 12:51:57 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 6a6327ad630a4a9d01853305eec06238771eedba #10 2024-05-08 12:53:45 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 0febb51a94ebb2f0412009ad1d675b8c41d79853 #11 2024-05-13 13:39:15 ~4 min tests :page_facing_up:log
:heavy_check_mark: 0febb51a94ebb2f0412009ad1d675b8c41d79853 #11 2024-05-13 13:41:50 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 0febb51a94ebb2f0412009ad1d675b8c41d79853 #11 2024-05-13 13:41:53 ~7 min android :robot:apk :calling:
:heavy_check_mark: 0febb51a94ebb2f0412009ad1d675b8c41d79853 #11 2024-05-13 13:44:43 ~9 min ios :iphone:ipa :calling:

status-im-auto avatar May 08 '24 07:05 status-im-auto

Thank you for the feature and clever approach. This method is better than mine in #19929.

I'm gonna close my PR and chill

Chilling...

shivekkhurana avatar May 08 '24 09:05 shivekkhurana

To whoever will be testing this: need to make sure that page-nav doesn't break elsewhere, nothing else really needs to be checked because we're hiding this feature behind the feature flag now.

alwx avatar May 08 '24 12:05 alwx

85% of end-end tests have passed

Total executed tests: 52
Failed tests: 6
Expected to fail tests: 2
Passed tests: 44

IDs of failed tests: 727230,704613,727229,702807,727232,702775 

IDs of expected to fail tests: 703495,703503

Failed tests (6)

Click to expand
  • Rerun failed tests

    • Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Find `EditBox` by `accessibility id`: `add-address-to-watch`
    Device 1: Type `0x8d2413447ff297d30bdc475f6d5cb00254685aae` to `EditBox` 
    critical/test_wallet.py:190: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:120: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button 
    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab 
    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 
    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 
    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:39: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 
    critical/test_wallet.py:109: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:99: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:86: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:80: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 
    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]]

    Device sessions

    Passed tests (44)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    status-im-auto avatar May 08 '24 14:05 status-im-auto

     @alwx  thank you for detailed description!  One question - do you know where page-nav is used? it is a part of basic navigation?

    churik avatar May 09 '24 13:05 churik

    Thanks for your work @alwx! I couldn't find any regression, PR can be merged.

    qoqobolo avatar May 13 '24 13:05 qoqobolo