status-mobile
status-mobile copied to clipboard
Collectibles not displayed after account recovery #18613
fixes #18613
When a new account address is added successfully:
https://github.com/status-im/status-mobile/assets/55688834/28775426-7098-430b-850c-3b56c7c8db1e
When an account is recovered (i.e. using recovery phrase), this is the list of accounts that are returned from back end which is only one account address:
But when the same account is logged in, all of the accounts are returned:
Jenkins Builds
Click to see older builds (23)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 39ecfc38beaa4048f181be52fa7d07f8b76146d3 | #1 | 2024-04-10 12:38:07 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 39ecfc38beaa4048f181be52fa7d07f8b76146d3 | #1 | 2024-04-10 12:40:18 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 39ecfc38beaa4048f181be52fa7d07f8b76146d3 | #1 | 2024-04-10 12:40:44 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 39ecfc38beaa4048f181be52fa7d07f8b76146d3 | #1 | 2024-04-10 14:11:05 | ~1 hr 37 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 9df51e9b1005986d5679985bcc9a57a1c6d8d938 | #2 | 2024-04-10 15:05:44 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 9df51e9b1005986d5679985bcc9a57a1c6d8d938 | #2 | 2024-04-10 15:09:20 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 9df51e9b1005986d5679985bcc9a57a1c6d8d938 | #2 | 2024-04-10 15:09:43 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 9df51e9b1005986d5679985bcc9a57a1c6d8d938 | #2 | 2024-04-10 15:15:26 | ~13 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 4292abd96b7e6874e97ec06dfcc70b2f17ce1ce6 | #3 | 2024-04-10 16:30:29 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 4292abd96b7e6874e97ec06dfcc70b2f17ce1ce6 | #3 | 2024-04-10 16:30:42 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 4292abd96b7e6874e97ec06dfcc70b2f17ce1ce6 | #3 | 2024-04-10 16:33:43 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | b6f48ded4551059f098e80900a1202f9f13dd581 | #4 | 2024-04-11 14:16:06 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | b6f48ded4551059f098e80900a1202f9f13dd581 | #4 | 2024-04-11 14:16:36 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | b6f48ded4551059f098e80900a1202f9f13dd581 | #4 | 2024-04-11 14:19:24 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | b6f48ded4551059f098e80900a1202f9f13dd581 | #4 | 2024-04-11 14:21:53 | ~11 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | a46ee91330380d00865adc6f8ec3d376b9d618a0 | #5 | 2024-04-15 13:36:12 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | a46ee91330380d00865adc6f8ec3d376b9d618a0 | #5 | 2024-04-15 13:39:53 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | a46ee91330380d00865adc6f8ec3d376b9d618a0 | #5 | 2024-04-15 13:40:08 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | a46ee91330380d00865adc6f8ec3d376b9d618a0 | #5 | 2024-04-15 13:41:22 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | feff1181f03beb94bff946886847d44d12ce133d | #6 | 2024-04-15 15:27:01 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | feff1181f03beb94bff946886847d44d12ce133d | #6 | 2024-04-15 15:27:56 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | feff1181f03beb94bff946886847d44d12ce133d | #6 | 2024-04-15 15:28:07 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | feff1181f03beb94bff946886847d44d12ce133d | #6 | 2024-04-15 15:31:30 | ~10 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 8925327ef8588c3facfa80acb9d6ba3f94c5f71e | #7 | 2024-04-16 12:54:14 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 8925327ef8588c3facfa80acb9d6ba3f94c5f71e | #7 | 2024-04-16 12:56:38 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 8925327ef8588c3facfa80acb9d6ba3f94c5f71e | #7 | 2024-04-16 12:57:10 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 8925327ef8588c3facfa80acb9d6ba3f94c5f71e | #7 | 2024-04-16 13:04:14 | ~15 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | ab70ade18d3172d87f3c79e5b9810e6aee1456b0 | #8 | 2024-04-16 14:30:44 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | ab70ade18d3172d87f3c79e5b9810e6aee1456b0 | #8 | 2024-04-16 14:32:28 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | ab70ade18d3172d87f3c79e5b9810e6aee1456b0 | #8 | 2024-04-16 14:33:37 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | ab70ade18d3172d87f3c79e5b9810e6aee1456b0 | #8 | 2024-04-16 14:37:56 | ~11 min | ios |
:iphone:ipa :calling: |
90% of end-end tests have passed
Total executed tests: 52
Failed tests: 3
Expected to fail tests: 2
Passed tests: 47
IDs of failed tests: 727230,702869,727232
IDs of expected to fail tests: 703495,703503
Failed tests (3)
Click to expand
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_watch_only_account, id: 727232 |
Device 1: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_undo_delete_message, id: 702869 |
Device 1: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
Device 1: Device 2: |
Expected to fail tests (2)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Passed tests (47)
Click to expand
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 4. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_join_send_text_messages_push, id: 702807 |
| Device sessions Device 1: Device 2: Device 3: |
| 5. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
| Device sessions Device 1: |
| 2. test_links_deep_links, id: 702775 |
| Device sessions Device 1: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_eth, id: 727229 |
| Device sessions Device 1: Device 2: |
Hi @mmilad75 thank you for PR. Unfortunately, the issue still reproduces. Collectibles are not shown after initial recovering
PR_ISSUE 1: Collectibles not displayed after account recovery
Steps:
- Recover the account with some collectibles
- Go to the 'collectibles' tab
Actual result:
The collectibles are not displayed until the user performs a re-login.
https://github.com/status-im/status-mobile/assets/52490791/5422b546-29e3-46ae-a072-eb54c4b9f8e0
Expected result:
The collectibles should be immediately visible as soon as the recovered user opens the 'Collectibles' tab after account recovery
OS:
IOS, Android
Devices:
- Pixel 7a, Android 13
- iPhone 11 Pro Max, IOS 17
Logs
PR_ISSUE 2: App crashes when log out is performed
Steps:
- Recover the user with collectibles
- Log out
Actual result:
https://github.com/status-im/status-mobile/assets/52490791/f134615d-91ac-4055-aee4-8ab167efcbbe
Expected result:
App is not crashed
Additional info:
That's interesting, this issue happens only with one particular user. I tried it with other users who also have collectibles, but issue do not reproduce then
OS:
IOS, Android
Devices:
- Pixel 7a, Android 13
- iPhone 11 Pro Max, IOS 17
Logs
PR_ISSUE 3: The collectibles are not fetched when watch only account with available collectibles is added
Steps:
- Add watch-only with collectibles (in my case:
0x8d51191dd7e371bd88ab9797b11b03da3084de6e) - Check if the collectibles are fetched
Actual result:
The collectibles are not displayed when watch-only acc is added until the user performs a re-login.
https://github.com/status-im/status-mobile/assets/52490791/d38e065d-4d88-43cf-a36e-fcf56c501fbb
Expected result:
The collectibles are displayed as soon as the watch-only acc is added
OS:
IOS, Android
Devices:
- Pixel 7a, Android 13
- iPhone 11 Pro Max, IOS 17
Logs
- 0x8d51191dd7e371bd88ab9797b11b03da3084de6e
Can you please test again?
83% of end-end tests have passed
Total executed tests: 52
Failed tests: 7
Expected to fail tests: 2
Passed tests: 43
IDs of failed tests: 727230,702809,702948,727229,702786,702845,703629
IDs of expected to fail tests: 703495,703503
Failed tests (7)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
Device 1: Device 2: |
| 2. test_wallet_send_eth, id: 727229 |
Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
|
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
|
| 3. test_community_mentions_push_notification, id: 702786 |
Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
|
| 5. test_community_join_when_node_owner_offline, id: 703629 |
|
Expected to fail tests (2)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (43)
Click to expand
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_join_send_text_messages_push, id: 702807 |
| Device sessions Device 1: Device 2: Device 3: |
| 5. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
| Device sessions Device 1: |
| 2. test_links_deep_links, id: 702775 |
| Device sessions Device 1: |
Hi @mmilad75
- Issue 2 is fixed
- Unfortunately the issue 3 still reproducible. Collectibles are not fetched when watch - only account is added. I am trying to add this
0x8d2413447ff297d30bdc475f6d5cb00254685aaeone
https://github.com/status-im/status-mobile/assets/52490791/7530c9b6-453e-46d3-9ac7-34ce272c490c
Devices:
- Pixel 7a, Android 13
- iPhone 11 Pro Max, IOS 17
Logs
ios logs logs (18).zip android logs Status-debug-logs (2).zip
71% of end-end tests have passed
Total executed tests: 7
Failed tests: 2
Expected to fail tests: 0
Passed tests: 5
IDs of failed tests: 727230,727229
Failed tests (2)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
Device 1: Device 2: |
| 2. test_wallet_send_eth, id: 727229 |
Device 1: Device 2: |
Passed tests (5)
Click to expand
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 2. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 3. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 4. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
@mmilad75 - what's the status of this pr? 🤔
@mmilad75 - what's the status of this pr? 🤔
Please check the description of this PR and also https://github.com/status-im/status-mobile/issues/18613#issuecomment-2061323513
lets close it for now, feel free to reopen
Hi @flexsurfer . Just wondering why we are closing this issue. It's still сan be reproduced
hey @VolodLytvynenko we're not closing issue, just stale PR
hey @VolodLytvynenko we're not closing issue, just stale PR
@smohamedjavid was solving an issue which contains these changes