status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

[#13992] Delete account only after moving keys to keyacard

Open rasom opened this issue 3 years ago • 1 comments

status: wip

fix #13992

rasom avatar Sep 20 '22 10:09 rasom

Jenkins Builds

Click to see older builds (28)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: c6001119 #1 2022-09-20 10:47:39 ~1 min tests :package:log
:heavy_check_mark: c6001119 #1 2022-09-20 10:53:51 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: c6001119 #1 2022-09-20 10:54:42 ~8 min android :package:apk :calling:
:heavy_check_mark: c6001119 #1 2022-09-20 11:00:06 ~14 min ios :package:ipa :calling:
:heavy_check_mark: 332f22d8 #2 2022-09-20 11:10:45 ~2 min tests :package:log
:heavy_check_mark: 332f22d8 #2 2022-09-20 11:16:07 ~7 min android :package:apk :calling:
:heavy_check_mark: 332f22d8 #2 2022-09-20 11:18:10 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: 332f22d8 #2 2022-09-20 11:22:28 ~14 min ios :package:ipa :calling:
:heavy_check_mark: 6249010a #3 2022-09-20 11:26:07 ~2 min tests :package:log
:heavy_check_mark: 6249010a #3 2022-09-20 11:31:55 ~7 min android :package:apk :calling:
:heavy_check_mark: 6249010a #3 2022-09-20 11:32:18 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: 6249010a #3 2022-09-20 11:36:30 ~12 min ios :package:ipa :calling:
:heavy_check_mark: 56bd9323 #4 2022-09-20 11:50:18 ~1 min tests :package:log
:heavy_check_mark: 56bd9323 #4 2022-09-20 11:55:31 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 56bd9323 #4 2022-09-20 11:55:59 ~7 min android :package:apk :calling:
:heavy_check_mark: 56bd9323 #4 2022-09-20 12:03:26 ~15 min ios :package:ipa :calling:
:heavy_check_mark: 41184d98 #5 2022-09-22 08:14:09 ~1 min tests :package:log
:heavy_check_mark: 41184d98 #5 2022-09-22 08:19:34 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 41184d98 #5 2022-09-22 08:19:46 ~7 min android :package:apk :calling:
:heavy_check_mark: 41184d98 #5 2022-09-22 08:25:19 ~13 min ios :package:ipa :calling:
:heavy_check_mark: fc5361d9 #6 2022-09-22 08:54:45 ~2 min tests :package:log
:heavy_check_mark: fc5361d9 #6 2022-09-22 09:00:21 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: fc5361d9 #6 2022-09-22 09:01:05 ~8 min android :package:apk :calling:
:heavy_check_mark: e96b902e #7 2022-09-22 09:08:48 ~2 min tests :package:log
:heavy_check_mark: aed488c5 #8 2022-09-22 09:13:24 ~1 min tests :package:log
:heavy_check_mark: aed488c5 #8 2022-09-22 09:18:50 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: aed488c5 #8 2022-09-22 09:19:03 ~7 min android :package:apk :calling:
:heavy_check_mark: aed488c5 #8 2022-09-22 09:24:13 ~12 min ios :package:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 847277f3 #9 2022-09-27 12:58:16 ~2 min tests :package:log
:heavy_check_mark: 847277f3 #9 2022-09-27 13:03:32 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 847277f3 #9 2022-09-27 13:03:52 ~7 min android :package:apk :calling:
:heavy_check_mark: 847277f3 #9 2022-09-27 13:08:28 ~12 min ios :package:ipa :calling:
:heavy_check_mark: 7f1e8367 #10 2022-09-30 09:23:08 ~2 min tests :package:log
:heavy_check_mark: 7f1e8367 #10 2022-09-30 09:28:42 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 7f1e8367 #10 2022-09-30 09:29:06 ~8 min android :package:apk :calling:
:heavy_check_mark: 7f1e8367 #10 2022-09-30 09:32:52 ~11 min ios :package:ipa :calling:

status-im-auto avatar Sep 20 '22 10:09 status-im-auto

97% of end-end tests have passed

Total executed tests: 87
Failed tests: 3
Passed tests: 84
IDs of failed tests: 6263,702076,702189 

Failed tests (3)

Click to expand
  • Rerun failed tests

  • Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

    Device 1: Click until `EditBox` by `accessibility id`: `chat-message-input` will be presented
    Device 1: Wait for text element `TransactionStatus` to be equal to `Confirmed`
    critical/chats/test_1_1_public_chats.py:200: in test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline
        [message.transaction_status.wait_for_element_text(message.confirmed, wait_time=120) for message in
    critical/chats/test_1_1_public_chats.py:200: in <listcomp>
        [message.transaction_status.wait_for_element_text(message.confirmed, wait_time=120) for message in
    ../views/base_element.py:152: in wait_for_element_text
        self.driver.fail(
    base_test_case.py:177: in fail
        pytest.fail('Device %s: %s' % (self.number, text))
     Device 1: `Pending` is not equal to expected `Confirmed` in 120 sec
    



    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_browser_delete_close_tabs, id: 702076

    Device 1: Find Button by xpath: //*[contains(@text, 'bbc.com')]/../../../../*[@content-desc='empty-tab']
    Device 1: Tap on found: Button
    critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs
        web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element()
    ../views/base_element.py:144: in wait_for_invisibility_of_element
        raise TimeoutException("Device %s: %s by %s: `%s`  is still visible on the screen after %s seconds after wait_for_invisibility_of_element" % (
     Device 1: Button by xpath: `//*[contains(@text, "bbc.com")]`  is still visible on the screen after 10 seconds after wait_for_invisibility_of_element
    



    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Device 1: Enter default pin 111111
    Device 1: Enter default pin 111111
    critical/onboarding/test_onboarding_flows.py:439: in test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx
        self.driver.fail("No popup about successfull migration is shown!")
     'TestRestoreOneDeviceMerged' object has no attribute 'driver'
    



    Device sessions

    Passed tests (84)

    Click to expand

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    2. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
    Device sessions

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
    Device sessions

    2. test_1_1_chat_message_reaction, id: 6315
    Device sessions

    3. test_1_1_chat_audio_message_with_push, id: 6316
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
    Device sessions

    5. test_1_1_chat_image_send_save_reply, id: 6305
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
    Device sessions

    7. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
    Device sessions

    8. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
    Device sessions

    9. test_1_1_chat_push_emoji, id: 6283
    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157
    Device sessions

    2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
    Device sessions

    3. test_ens_mention_push_highlighted_public_chat, id: 702156
    Device sessions

    4. test_ens_mention_nickname_1_1_chat, id: 702155
    Device sessions

    5. test_ens_purchased_in_profile, id: 702152
    Device sessions

    6. test_start_new_chat_public_key_validation, id: 702158
    Device sessions

    Class TestPublicChatMultipleDeviceMerged:

    1. test_public_chat_message_edit, id: 700734
    Device sessions

    2. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    3. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    4. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    5. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    6. test_public_chat_link_send_open, id: 700736
    Device sessions

    7. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    8. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    9. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    10. test_public_chat_message_delete, id: 700735
    Device sessions

    Class TestWalletManagementDeviceMerged:

    1. test_wallet_manage_assets, id: 700758
    Device sessions

    2. test_wallet_add_account_seed_phrase_validation, id: 700762
    Device sessions

    3. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    4. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    5. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    6. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    7. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
    Device sessions

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    2. test_group_chat_highligted, id: 5756
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    4. test_group_chat_offline_pn, id: 3998
    Device sessions

    5. test_group_chat_add_new_member, id: 700732
    Device sessions

    6. test_group_chat_leave_relogin, id: 3997
    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    2. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    3. test_send_tx_token_8_decimals, id: 700764
    Device sessions

    4. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    5. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_contact_block_unblock_public_chat_offline, id: 702176
    Device sessions

    2. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    Device sessions

    3. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    Device sessions

    4. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
    Device sessions

    5. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    2. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    3. test_browser_blocked_url, id: 702072
    Device sessions

    4. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    5. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    6. test_public_chat_tag_message, id: 700738
    Device sessions

    7. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    8. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Device sessions

    9. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    10. test_browser_offline, id: 702075
    Device sessions

    11. test_browser_invalid_url, id: 702074
    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    2. test_restore_seed_phrase_field_validation, id: 700750
    Device sessions

    3. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    Class TestOnboardingOneDeviceMerged:

    1. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    2. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    3. test_onboarding_share_contact_address, id: 700743
    Device sessions

    4. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    5. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    2. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    3. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    4. test_keycard_send_tx_eth, id: 700767
    Device sessions

    5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    Class TestPairingSyncMultipleDevicesMerged:

    1. test_pairing_sync_clear_history, id: 702394
    Device sessions

    2. test_pairing_sync_contacts_block_unblock, id: 702196
    Device sessions

    3. test_pairing_sync_initial_profile_picture, id: 702392
    Device sessions

    4. test_pairing_sync_initial_bookmarks, id: 702393
    Device sessions

    5. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Device sessions

    6. test_pairing_sync_1_1_chat_message, id: 702198
    Device sessions

    7. test_pairing_sync_public_chat_add_remove, id: 702199
    Device sessions

    8. test_pairing_sync_initial_public_chats, id: 702195
    Device sessions

    9. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
    Device sessions

    status-im-auto avatar Sep 22 '22 10:09 status-im-auto

    67% of end-end tests have passed

    Total executed tests: 3
    Failed tests: 1
    Passed tests: 2
    
    IDs of failed tests: 702189 
    

    Failed tests (1)

    Click to expand
  • Rerun failed tests

  • Class TestRestoreOneDeviceMerged:

    1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

    Device 1: Enter default pin 111111
    Device 1: Enter default pin 111111
    critical/onboarding/test_onboarding_flows.py:439: in test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx
        self.driver.fail("No popup about successfull migration is shown!")
     'TestRestoreOneDeviceMerged' object has no attribute 'driver'
    



    Device sessions

    Passed tests (2)

    Click to expand

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_browser_delete_close_tabs, id: 702076
    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    status-im-auto avatar Sep 23 '22 10:09 status-im-auto

    @rasom there is an issue in keycard framework, that I cannot finish the migration. I couldn't reproduce it on a real device, but worth taking a look as it blocks e2e.

    It is a reason for failed e2e. After confirming PIN when migrating multi-account nothing happened.

    Video: https://app.saucelabs.com/tests/70dcde7b430d4f09b85ee780bf49e723 Log: test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx_geth1.log

    churik avatar Sep 23 '22 11:09 churik

    @churik should be fixed now

    rasom avatar Sep 27 '22 15:09 rasom

    100% of end-end tests have passed

    Total executed tests: 1
    Failed tests: 0
    Passed tests: 1
    

    Passed tests (1)

    Click to expand

    Class TestRestoreOneDeviceMerged:

    1. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
    Device sessions

    status-im-auto avatar Sep 29 '22 07:09 status-im-auto