status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

permission tag component

Open jo-mut opened this issue 3 years ago • 2 comments

fixes #13678

Summary This PR adds permission-tag component to quo2.preview

jo-mut avatar Aug 04 '22 10:08 jo-mut

Jenkins Builds

Click to see older builds (26)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: a72dacf6 #1 2022-08-04 10:32:07 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: a72dacf6 #1 2022-08-04 10:32:12 ~9 min android :package:apk :calling:
:heavy_check_mark: a72dacf6 #1 2022-08-04 10:33:17 ~10 min ios :package:ipa :calling:
:heavy_check_mark: e9ed3992 #3 2022-08-05 10:18:02 ~9 min android-e2e :package:apk :calling:
:heavy_check_mark: e9ed3992 #3 2022-08-05 10:20:16 ~11 min ios :package:ipa :calling:
:heavy_check_mark: e9ed3992 #3 2022-08-05 10:20:22 ~11 min android :package:apk :calling:
:heavy_check_mark: 172e10d7 #4 2022-08-07 22:32:35 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 172e10d7 #4 2022-08-07 22:33:29 ~8 min android :package:apk :calling:
:heavy_check_mark: 172e10d7 #4 2022-08-07 22:36:17 ~11 min ios :package:ipa :calling:
:heavy_check_mark: 6912c831 #5 2022-08-08 12:20:40 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 6912c831 #5 2022-08-08 12:20:50 ~7 min android :package:apk :calling:
:heavy_check_mark: 6912c831 #5 2022-08-08 12:23:19 ~10 min ios :package:ipa :calling:
:x: 482cf12a #6 2022-08-12 21:10:49 ~15 sec android :page_facing_up:log
:x: 482cf12a #6 2022-08-12 21:10:49 ~16 sec android-e2e :page_facing_up:log
:x: 482cf12a #6 2022-08-12 21:10:51 ~12 sec ios :page_facing_up:log
:x: fdf0e5a5 #7 2022-08-15 10:09:21 ~19 sec ios :page_facing_up:log
:x: fdf0e5a5 #7 2022-08-15 10:09:22 ~20 sec android :page_facing_up:log
:x: fdf0e5a5 #7 2022-08-15 10:09:23 ~21 sec android-e2e :page_facing_up:log
:heavy_multiplication_x: e1cef135 #8 2022-08-15 10:53:13 ~7 min android :package:apk :calling:
:heavy_multiplication_x: e1cef135 #8 2022-08-15 10:55:38 ~9 min android-e2e :package:apk :calling:
:heavy_multiplication_x: e1cef135 #8 2022-08-15 10:59:47 ~13 min ios :package:ipa :calling:
:heavy_check_mark: e082f568 #9 2022-08-15 22:18:41 ~8 min android :package:apk :calling:
:heavy_check_mark: e082f568 #9 2022-08-15 22:20:15 ~10 min ios :package:ipa :calling:
:heavy_check_mark: 93108769 #11 2022-08-16 19:54:54 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: 93108769 #11 2022-08-16 19:55:09 ~8 min android :package:apk :calling:
:heavy_check_mark: 93108769 #11 2022-08-16 20:01:13 ~14 min ios :package:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 75c8dd93 #12 2022-08-17 22:02:02 ~7 min android-e2e :package:apk :calling:
:heavy_check_mark: 75c8dd93 #12 2022-08-17 22:02:13 ~7 min android :package:apk :calling:
:heavy_check_mark: 75c8dd93 #12 2022-08-17 22:08:55 ~14 min ios :package:ipa :calling:
:heavy_check_mark: e988795b #13 2022-08-18 10:12:28 ~8 min android :package:apk :calling:
:heavy_check_mark: e988795b #13 2022-08-18 10:15:50 ~12 min android-e2e :package:apk :calling:
:heavy_check_mark: e988795b #13 2022-08-18 10:16:29 ~12 min ios :package:ipa :calling:

status-im-auto avatar Aug 04 '22 10:08 status-im-auto

Looks great! :)

One thing I noticed is that when I checked out your branch the console has some warnings ->

Warning: Encountered two children with the same key, `39`. Keys should be unique so that components maintain their identity across updates. 
...

Might be worth looking into where you're using two elements with the same key to keep the console clean.

J-Son89 avatar Aug 10 '22 09:08 J-Son89

the logic for this component is not yet very decided so i just came with code to show the design. The final code will maybe be quite different but my guess is not by much

jo-mut avatar Aug 17 '22 18:08 jo-mut