status-go icon indicating copy to clipboard operation
status-go copied to clipboard

feat_: implement PR review workflow

Open siddarthkay opened this issue 1 year ago • 8 comments

Summary

This PR Implements a PR review workflow like this :

  • This action will check if breaking change label exists on PR.
  • if it does then @status-im/desktop-qa and @status-im/mobile-qa are asked for review on this PR.
  • Unless 1 person from @status-im/desktop-qa and @status-im/mobile-qa approve that PR the Github action will block the PR.
  • Only after these conditions match the Github action will allow merging of this PR.

siddarthkay avatar Sep 25 '24 10:09 siddarthkay

Jenkins Builds

Click to see older builds (134)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: bfe0b667 #1 2024-09-25 10:53:55 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: bfe0b667 #1 2024-09-25 10:56:08 ~3 min linux :package:zip
:heavy_check_mark: bfe0b667 #1 2024-09-25 10:56:51 ~4 min ios :package:zip
:heavy_check_mark: bfe0b667 #1 2024-09-25 10:57:13 ~5 min android :package:aar
:heavy_check_mark: bfe0b667 #1 2024-09-25 11:25:05 ~32 min tests :page_facing_up:log
:heavy_check_mark: 8a907589 #2 2024-09-25 10:57:23 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 8a907589 #2 2024-09-25 10:58:54 ~1 min android :package:aar
:heavy_check_mark: 8a907589 #2 2024-09-25 10:59:54 ~2 min ios :package:zip
:heavy_check_mark: 8a907589 #2 2024-09-25 11:00:35 ~4 min linux :package:zip
:heavy_check_mark: da414205 #3 2024-09-25 11:00:09 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: da414205 #3 2024-09-25 11:00:48 ~1 min android :package:aar
:heavy_check_mark: da414205 #3 2024-09-25 11:02:48 ~1 min linux :package:zip
:heavy_check_mark: da414205 #3 2024-09-25 11:02:57 ~2 min ios :package:zip
:heavy_check_mark: 54ff2e6c #4 2024-09-25 11:08:00 ~1 min android :package:aar
:heavy_check_mark: 54ff2e6c #4 2024-09-25 11:08:22 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 54ff2e6c #4 2024-09-25 11:08:33 ~1 min linux :package:zip
:heavy_check_mark: 54ff2e6c #4 2024-09-25 11:09:22 ~2 min ios :package:zip
:heavy_check_mark: 54ff2e6c #2 2024-09-25 11:57:42 ~32 min tests :page_facing_up:log
:heavy_check_mark: 49a93647 #5 2024-09-25 12:38:22 ~1 min android :package:aar
:heavy_check_mark: 49a93647 #5 2024-09-25 12:38:33 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 49a93647 #5 2024-09-25 12:38:52 ~2 min linux :package:zip
:heavy_check_mark: 49a93647 #5 2024-09-25 12:41:56 ~5 min ios :package:zip
:heavy_check_mark: 49a93647 #3 2024-09-25 13:09:28 ~32 min tests :page_facing_up:log
:heavy_check_mark: 0b606e46 #6 2024-09-25 13:47:51 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 0b606e46 #6 2024-09-25 13:47:52 ~1 min android :package:aar
:heavy_check_mark: 0b606e46 #6 2024-09-25 13:48:17 ~2 min linux :package:zip
:heavy_check_mark: 0b606e46 #6 2024-09-25 13:49:12 ~3 min ios :package:zip
:heavy_check_mark: 0b606e46 #4 2024-09-25 14:16:11 ~29 min tests :page_facing_up:log
:heavy_check_mark: 6b552c15 #7 2024-09-25 15:56:19 ~1 min android :package:aar
:heavy_check_mark: 6b552c15 #7 2024-09-25 15:56:28 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 6b552c15 #7 2024-09-25 15:56:58 ~2 min linux :package:zip
:heavy_check_mark: 6b552c15 #7 2024-09-25 15:58:00 ~3 min ios :package:zip
:heavy_check_mark: 6b552c15 #5 2024-09-25 16:27:33 ~32 min tests :page_facing_up:log
:heavy_check_mark: 1fb7f362 #8 2024-09-29 16:24:03 ~1 min android :package:aar
:heavy_check_mark: 1fb7f362 #8 2024-09-29 16:24:19 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 1fb7f362 #8 2024-09-29 16:24:33 ~2 min linux :package:zip
:heavy_check_mark: 1fb7f362 #8 2024-09-29 16:25:40 ~3 min ios :package:zip
:heavy_check_mark: 1fb7f362 #6 2024-09-29 16:54:17 ~31 min tests :page_facing_up:log
:heavy_check_mark: 03dc7754 #9 2024-09-29 16:26:58 ~2 min android :package:aar
:heavy_check_mark: 03dc7754 #9 2024-09-29 16:27:15 ~2 min tests-rpc :page_facing_up:log
:heavy_check_mark: 03dc7754 #9 2024-09-29 16:27:26 ~2 min linux :package:zip
:heavy_check_mark: 03dc7754 #9 2024-09-29 16:29:05 ~3 min ios :package:zip
:heavy_check_mark: a3ef6313 #10 2024-09-29 16:33:07 ~1 min android :package:aar
:heavy_check_mark: a3ef6313 #10 2024-09-29 16:33:18 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: a3ef6313 #10 2024-09-29 16:33:38 ~1 min linux :package:zip
:heavy_check_mark: a3ef6313 #10 2024-09-29 16:34:24 ~2 min ios :package:zip
:heavy_check_mark: a3ef6313 #7 2024-09-29 17:26:16 ~31 min tests :page_facing_up:log
:heavy_check_mark: 3af26d08 #11 2024-09-30 02:45:47 ~1 min android :package:aar
:heavy_check_mark: 3af26d08 #11 2024-09-30 02:45:57 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 3af26d08 #11 2024-09-30 02:46:24 ~1 min linux :package:zip
:heavy_check_mark: 3af26d08 #11 2024-09-30 02:47:28 ~3 min ios :package:zip
:heavy_multiplication_x: 3af26d08 #8 2024-09-30 03:02:06 ~17 min tests :page_facing_up:log
:heavy_check_mark: f551c6f9 #12 2024-09-30 03:00:28 ~1 min android :package:aar
:heavy_check_mark: f551c6f9 #12 2024-09-30 03:00:30 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: f551c6f9 #12 2024-09-30 03:01:00 ~1 min linux :package:zip
:heavy_check_mark: f551c6f9 #12 2024-09-30 03:01:56 ~2 min ios :package:zip
:heavy_check_mark: 0daf1a41 #13 2024-09-30 03:02:42 ~1 min android :package:aar
:heavy_check_mark: 0daf1a41 #13 2024-09-30 03:02:48 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 0daf1a41 #13 2024-09-30 03:03:26 ~2 min linux :package:zip
:heavy_check_mark: 0daf1a41 #13 2024-09-30 03:05:04 ~2 min ios :package:zip
:heavy_check_mark: 0daf1a41 #9 2024-09-30 03:34:09 ~31 min tests :page_facing_up:log
:heavy_multiplication_x: 09d1d763 #10 2024-09-30 06:23:38 ~1 min tests :page_facing_up:log
:heavy_check_mark: 09d1d763 #14 2024-09-30 06:23:59 ~1 min android :package:aar
:heavy_check_mark: 09d1d763 #14 2024-09-30 06:23:59 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 09d1d763 #14 2024-09-30 06:24:24 ~1 min linux :package:zip
:heavy_check_mark: 09d1d763 #14 2024-09-30 06:25:22 ~2 min ios :package:zip
:heavy_multiplication_x: 3e1e6cee #11 2024-09-30 06:25:12 ~56 sec tests :page_facing_up:log
:heavy_check_mark: 3e1e6cee #15 2024-09-30 06:25:47 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 3e1e6cee #15 2024-09-30 06:25:56 ~1 min android :package:aar
:heavy_check_mark: 3e1e6cee #15 2024-09-30 06:26:32 ~1 min linux :package:zip
:heavy_check_mark: 3e1e6cee #15 2024-09-30 06:28:23 ~2 min ios :package:zip
:heavy_check_mark: 3dcc754c #16 2024-09-30 06:54:18 ~1 min android :package:aar
:heavy_check_mark: 3dcc754c #16 2024-09-30 06:54:21 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 3dcc754c #16 2024-09-30 06:54:51 ~1 min linux :package:zip
:heavy_check_mark: 3dcc754c #16 2024-09-30 06:55:49 ~3 min ios :package:zip
:heavy_check_mark: 3dcc754c #12 2024-09-30 07:24:23 ~31 min tests :page_facing_up:log
:heavy_check_mark: 8a787ca6 #17 2024-09-30 06:56:11 ~1 min android :package:aar
:heavy_check_mark: 8a787ca6 #17 2024-09-30 06:56:18 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 8a787ca6 #17 2024-09-30 06:57:05 ~2 min linux :package:zip
:heavy_check_mark: 8a787ca6 #17 2024-09-30 06:58:59 ~2 min ios :package:zip
:heavy_check_mark: 84ae517e #18 2024-09-30 06:58:26 ~1 min android :package:aar
:heavy_check_mark: 84ae517e #18 2024-09-30 06:58:32 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 84ae517e #18 2024-09-30 06:59:18 ~1 min linux :package:zip
:heavy_check_mark: 84ae517e #18 2024-09-30 07:02:00 ~2 min ios :package:zip
:heavy_check_mark: a85f68cf #19 2024-09-30 07:03:49 ~1 min android :package:aar
:heavy_check_mark: a85f68cf #19 2024-09-30 07:03:59 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: a85f68cf #19 2024-09-30 07:04:29 ~1 min linux :package:zip
:heavy_check_mark: a85f68cf #19 2024-09-30 07:05:26 ~2 min ios :package:zip
:heavy_check_mark: a85f68cf #13 2024-09-30 07:55:25 ~30 min tests :page_facing_up:log
:heavy_check_mark: 1183e551 #20 2024-10-01 03:54:38 ~1 min android :package:aar
:heavy_check_mark: 1183e551 #20 2024-10-01 03:54:54 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 1183e551 #20 2024-10-01 03:55:21 ~2 min linux :package:zip
:heavy_check_mark: 1183e551 #20 2024-10-01 03:56:26 ~3 min ios :package:zip
:heavy_check_mark: 1183e551 #14 2024-10-01 04:24:23 ~31 min tests :page_facing_up:log
:heavy_check_mark: 70086b52 #21 2024-10-01 04:02:27 ~1 min android :package:aar
:heavy_check_mark: 70086b52 #21 2024-10-01 04:03:03 ~1 min linux :package:zip
:heavy_check_mark: 70086b52 #21 2024-10-01 04:03:42 ~2 min tests-rpc :page_facing_up:log
:heavy_check_mark: 70086b52 #21 2024-10-01 04:04:56 ~3 min ios :package:zip
:heavy_check_mark: 301fe0df #22 2024-10-01 04:05:34 ~1 min android :package:aar
:heavy_check_mark: 301fe0df #22 2024-10-01 04:05:45 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 301fe0df #22 2024-10-01 04:06:05 ~1 min linux :package:zip
:heavy_check_mark: 301fe0df #22 2024-10-01 04:08:19 ~3 min ios :package:zip
:heavy_check_mark: be288753 #23 2024-10-01 04:10:40 ~1 min android :package:aar
:heavy_check_mark: be288753 #23 2024-10-01 04:10:51 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: be288753 #23 2024-10-01 04:11:28 ~2 min linux :package:zip
:heavy_check_mark: be288753 #23 2024-10-01 04:12:31 ~3 min ios :package:zip
:heavy_check_mark: 455c661a #24 2024-10-01 04:21:50 ~1 min android :package:aar
:heavy_check_mark: 455c661a #24 2024-10-01 04:22:32 ~2 min linux :package:zip
:heavy_check_mark: 455c661a #24 2024-10-01 04:22:59 ~2 min tests-rpc :page_facing_up:log
:heavy_check_mark: 455c661a #24 2024-10-01 04:23:07 ~2 min ios :package:zip
:heavy_check_mark: 455c661a #15 2024-10-01 04:54:51 ~30 min tests :page_facing_up:log
:heavy_check_mark: 79e8afc5 #25 2024-10-01 04:29:24 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 79e8afc5 #25 2024-10-01 04:29:33 ~1 min android :package:aar
:heavy_check_mark: 79e8afc5 #25 2024-10-01 04:30:50 ~3 min ios :package:zip
:heavy_check_mark: 79e8afc5 #25 2024-10-01 04:31:22 ~3 min linux :package:zip
:heavy_check_mark: 0d81b866 #26 2024-10-01 04:43:25 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: 0d81b866 #26 2024-10-01 04:43:39 ~1 min android :package:aar
:heavy_check_mark: 0d81b866 #26 2024-10-01 04:43:58 ~1 min linux :package:zip
:heavy_check_mark: 0d81b866 #26 2024-10-01 04:44:47 ~2 min ios :package:zip
:heavy_check_mark: a677c761 #27 2024-10-01 04:45:12 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: a677c761 #27 2024-10-01 04:45:32 ~1 min android :package:aar
:heavy_check_mark: a677c761 #27 2024-10-01 04:46:10 ~1 min linux :package:zip
:heavy_check_mark: a677c761 #27 2024-10-01 04:48:02 ~3 min ios :package:zip
:heavy_check_mark: a677c761 #16 2024-10-01 05:25:33 ~30 min tests :page_facing_up:log
:heavy_check_mark: b56e69dc #28 2024-10-03 10:40:23 ~2 min android :package:aar
:heavy_check_mark: b56e69dc #28 2024-10-03 10:40:31 ~2 min linux :package:zip
:heavy_check_mark: b56e69dc #28 2024-10-03 10:41:18 ~3 min tests-rpc :page_facing_up:log
:heavy_check_mark: b56e69dc #28 2024-10-03 10:42:24 ~4 min ios :package:zip
:heavy_check_mark: b56e69dc #17 2024-10-03 11:10:48 ~32 min tests :page_facing_up:log
:heavy_check_mark: 23a73a78 #29 2024-10-03 11:31:59 ~1 min android :package:aar
:heavy_check_mark: 23a73a78 #29 2024-10-03 11:32:46 ~2 min tests-rpc :page_facing_up:log
:heavy_check_mark: 23a73a78 #29 2024-10-03 11:32:58 ~2 min linux :package:zip
:heavy_check_mark: 23a73a78 #29 2024-10-03 11:33:34 ~2 min ios :package:zip
:heavy_multiplication_x: 23a73a78 #18 2024-10-03 12:04:11 ~33 min tests :page_facing_up:log
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: f2438bbd #30 2024-10-03 11:34:44 ~1 min android :package:aar
:heavy_check_mark: f2438bbd #30 2024-10-03 11:35:23 ~2 min linux :package:zip
:heavy_check_mark: f2438bbd #30 2024-10-03 11:36:21 ~2 min ios :package:zip
:heavy_check_mark: f2438bbd #30 2024-10-03 11:36:26 ~3 min tests-rpc :page_facing_up:log
:heavy_check_mark: fc73ab2b #31 2024-10-03 11:45:28 ~1 min android :package:aar
:heavy_check_mark: fc73ab2b #31 2024-10-03 11:45:48 ~1 min tests-rpc :page_facing_up:log
:heavy_check_mark: fc73ab2b #31 2024-10-03 11:46:02 ~2 min linux :package:zip
:heavy_check_mark: fc73ab2b #31 2024-10-03 11:46:38 ~2 min ios :package:zip
:heavy_check_mark: fc73ab2b #19 2024-10-03 12:35:47 ~31 min tests :page_facing_up:log

status-im-auto avatar Sep 25 '24 10:09 status-im-auto

Looks like you have BREAKING CHANGES in your PR. Please make sure to follow 💔How to introduce breaking changes guide:

Check-list

github-actions[bot] avatar Sep 25 '24 10:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.09%. Comparing base (04784d1) to head (fc73ab2). Report is 40 commits behind head on develop.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5877      +/-   ##
===========================================
+ Coverage    45.42%   46.09%   +0.67%     
===========================================
  Files          891      891              
  Lines       158084   158082       -2     
===========================================
+ Hits         71808    72869    +1061     
+ Misses       78201    76848    -1353     
- Partials      8075     8365     +290     
Flag Coverage Δ
functional 11.85% <ø> (?)
unit 45.49% <ø> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 134 files with indirect coverage changes

codecov-commenter avatar Sep 25 '24 11:09 codecov-commenter

Hmmm

One or more of the teams you specified is not a collaborator of the status-im/status-go repository.

So it seems we will have to make the relevant teams inside status-go repository first. At the moment I see teams are made at Org level.

siddarthkay avatar Sep 25 '24 11:09 siddarthkay

@siddarthkay is it time to review this? Or are you still testing?

igor-sirotin avatar Sep 25 '24 17:09 igor-sirotin

so clearly the checks need more work! Thanks for the PR approval guys! I'll fix the issues.

siddarthkay avatar Sep 30 '24 10:09 siddarthkay

:heavy_check_mark: status-go/prs/android/PR-5877#23 :small_blue_diamond: ~1 min 35 sec :small_blue_diamond: be288753 :small_blue_diamond: :package: android package

status-im-auto avatar Oct 01 '24 04:10 status-im-auto

added a check to prevent the bot from approving the PR multiple times.

siddarthkay avatar Oct 01 '24 04:10 siddarthkay

Closing as not relevant at the moment. Thank you @siddarthkay anyway ❤️

igor-sirotin avatar Jul 02 '25 19:07 igor-sirotin