status-go
status-go copied to clipboard
status-im
feat: edit/delete/reply for emoji/sticker/audio
This is a pull request that completes the functionalities needed for issue #13246 on status-mobile.
Add missing actions (edit/delete/reply) to certain types of messages (emoji/sticker/audio)
To implement the needed functionalities there are 2 pull requests to this repo status-go and to status-mobile.
The pull request on status-mobile includes a full description of the features and how it is implemented.
Hey @OmarBasem, and thank you so much for making your first pull request in status-go! :heart: Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2
![status-github-bot[bot] avatar](https://avatars.githubusercontent.com/in/8157?v=4 "Published by a pub.dev verified publisher"){kind=small}
Pull Request Checklist
- [ ] Have you updated the documentation, if impacted (e.g. docs.status.im)?
- [ ] Have you tested changes with mobile?
- [ ] Have you tested changes with desktop?
Jenkins Builds
Click to see older builds (15)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 423d0a80 | #1 | 2022-07-25 07:36:48 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 423d0a80 | #1 | 2022-07-25 07:38:53 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | 423d0a80 | #1 | 2022-07-25 07:39:22 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | b6f15a5e | #2 | 2022-08-02 19:20:20 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | b6f15a5e | #2 | 2022-08-02 19:23:15 | ~5 min | ios |
:package:zip |
| :heavy_check_mark: | b6f15a5e | #2 | 2022-08-02 19:23:28 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | d885bd56 | #3 | 2022-08-02 19:31:59 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | d885bd56 | #3 | 2022-08-02 19:32:37 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | d885bd56 | #3 | 2022-08-02 19:33:40 | ~3 min | android |
:package:aar |
| :heavy_check_mark: | 14615a61 | #4 | 2022-08-03 05:28:55 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | 14615a61 | #4 | 2022-08-03 05:30:13 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 14615a61 | #4 | 2022-08-03 05:30:47 | ~3 min | android |
:package:aar |
| :heavy_check_mark: | 87db7d95 | #5 | 2022-08-03 05:30:24 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | 87db7d95 | #5 | 2022-08-03 05:32:29 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 87db7d95 | #5 | 2022-08-03 05:33:37 | ~2 min | android |
:package:aar |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 2168d62b | #6 | 2022-10-05 04:50:44 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 2168d62b | #6 | 2022-10-05 04:53:05 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | 2168d62b | #6 | 2022-10-05 04:53:10 | ~5 min | ios |
:package:zip |
| :heavy_check_mark: | 686d4b06 | #7 | 2022-10-05 17:42:36 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 686d4b06 | #7 | 2022-10-05 17:42:41 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 686d4b06 | #7 | 2022-10-05 17:43:58 | ~3 min | android |
:package:aar |
@Samyoul how better to manage it, as it contains 5 commits from forked repo? maybe to create a copy of this PR directly into our repo and merge it?
I see both PRs on the status-react and status-go side are a bit stuck due to the limited possibility of rebasing the forked repo.
@OmarBasem sorry for delay!
Thanks @churik, I don't see a problem with merging this PR.
@OmarBasem are you able to merge this PR? If not I am able to merge this for you.
@Samyoul can you please rebase it, squash the commits, I'll check for regression and then we merge?