status-go
status-go copied to clipboard
status-im
refactor: remove identicons
With this PR, Identicons are removed from status-go (spec)
Part of https://github.com/status-im/status-desktop/issues/4783
Set as draft because I still have to determine if the identicons will be removed in the login screen as well
Pull Request Checklist
- [ ] Have you updated the documentation, if impacted (e.g. docs.status.im)?
- [ ] Have you tested changes with mobile?
- [ ] Have you tested changes with desktop?
![status-github-bot[bot] avatar](https://avatars.githubusercontent.com/in/8157?v=4 "Published by a pub.dev verified publisher"){kind=small}
Jenkins Builds
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | b1468d8b | #1 | 2022-02-18 13:15:07 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | b1468d8b | #1 | 2022-02-18 13:17:22 | ~4 min | android |
:package:aar |
| :heavy_check_mark: | b1468d8b | #1 | 2022-02-18 13:17:29 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | b1468d8b | #2 | 2022-03-14 17:51:21 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | b1468d8b | #2 | 2022-03-14 17:52:36 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | b1468d8b | #2 | 2022-03-14 17:53:18 | ~4 min | android |
:package:aar |
@richard-ramos do we have to remove identicon in this PR? It makes is harder to merge, since it means that we also need to implement display name in status-react, but designs are not yet ready, so it would not be mergeable until then. If we keep both display name and identicon, we can merge this and status-react can keep using identicons until it's ready to integrate display names, and desktop can start using display names straight away, what do you think?
I also have some comments about versioning and display name, but I need to ask John for the details first.
I agree with both of you, @cammellos and @PascalPrecht. This PR shouldnt be merged until work in the mobile app and in desktop is complete. I can periodically rebase the changes from develop branch into this PR, so when the time comes when work in both apps is complete, we can merge it.
This PR is not strictly necessary for the display name work, but can be seen more of a code cleaning PR since it will remove code that eventually will not be used across all status clients