status-go
status-go copied to clipboard
status-im
Sync Community on SetMuted
Community muted state is sync on initial sync, but muted changes are not subsequently synced.
- [x] Add go tests
- ~~Check e2e tests with QA~~
Notes for QA
This functionality syncs the mute state of communities, we need to test that after a community has initially been synced further changes to the muted option sync between devices.
Pull Request Checklist
- [ ] Have you updated the documentation, if impacted (e.g. docs.status.im)?
- [ ] Have you tested changes with mobile?
- [ ] Have you tested changes with desktop?
![status-github-bot[bot] avatar](https://avatars.githubusercontent.com/in/8157?v=4 "Published by a pub.dev verified publisher"){kind=small}
Jenkins Builds
Click to see older builds (8)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | b8f4a71b | #1 | 2021-10-29 13:46:47 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | b8f4a71b | #1 | 2021-10-29 13:47:34 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | b8f4a71b | #1 | 2021-10-29 13:49:51 | ~6 min | android |
:package:aar |
| :heavy_check_mark: | 3c0dee24 | #2 | 2021-11-03 16:37:00 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 3c0dee24 | #2 | 2021-11-03 16:37:06 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 3c0dee24 | #2 | 2021-11-03 16:40:43 | ~6 min | android |
:package:aar |
| :heavy_check_mark: | aa64193b | #3 | 2021-11-03 16:48:48 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | aa64193b | #3 | 2021-11-03 16:49:21 | ~4 min | android |
:package:aar |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | af096151 | #4 | 2021-11-03 16:49:00 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | af096151 | #4 | 2021-11-03 16:50:53 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | af096151 | #4 | 2021-11-03 16:53:28 | ~4 min | android |
:package:aar |
| :heavy_check_mark: | 853d1b38 | #5 | 2022-05-27 10:08:35 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 853d1b38 | #5 | 2022-05-27 10:10:19 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | 853d1b38 | #5 | 2022-05-27 10:10:43 | ~4 min | android |
:package:aar |
Looks like mute is a desktop only feature, see https://github.com/status-im/status-react/pull/12788#issuecomment-960643072
Hey @churik yes it is relevant, but it is something that only impacts desktop. Community mute setting doesn't seem to be active on mobile.
Hey @anastasiyaig I've moved the PR back into client testing. In tests this functionality works, and devices update the muted state of communities between devices once a user syncs their devices.
i've tested this functionality and looks like it works the opposite I do expect. so when i have 2 instances of desktop, same community with same recovered account , both items are synced and then i switch the toggle OFF on one of the devices -> sync devices -> then both instances have the toggle ON (i was expecting it to be OFF)
@Samyoul what do u think?
https://user-images.githubusercontent.com/82375995/172648350-a4a1446e-6214-4e23-aa54-3dcebd219b30.mov
