Update deprecated dependency: github.com/golang/protobuf

[richard-ramos]

trafficstars

github.com/golang/protobuf 1.3.x are deprecated and the linter will complain with:

SA1019: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead

Unfortunately, updating this dependency is not a simple task, since it requires doing a lot of changes across the codebase, changing the usage of the protobuffers from simple structs to pointers: i.e.: protobuffer.ChatMessage should become *protobuffer.ChatMessage.

In the meantime, excluding the rule S1019 in the linter could be used to bypass this check

lint:
	@echo "lint"
	@golangci-lint --exclude=SA1019 run ./... --deadline=5m

[richard-ramos]

Updating the protobuf dependency also requires updating it in mvds. I did it in this PR https://github.com/vacp2p/mvds/pull/88 however it's not possible to use it due to this issue: https://github.com/vacp2p/mvds/issues/89 . It seems we are not using the latest mvds version in status-go, hence why this issue has not been noticed before

[richard-ramos]

A draft PR is being worked here: https://github.com/status-im/status-go/pull/2222 but it fails due to vacp2p/mvds#89

[status-github-bot[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.