status-go icon indicating copy to clipboard operation
status-go copied to clipboard

Installation timestamp is always 0

Open emizzle opened this issue 4 years ago • 1 comments
trafficstars

Problem

When advertising a device with the sendPairInstallation RPC call, the signal that is received on both device 1 and device 2 always shows a timestamp of 0.

Reproduction

  1. On device 1, advertise the device using sendPairInstallation.
  2. On device 2, monitor the signal coming in.
  3. Actual Result:
  {
  "type": "messages.new",
  "event": {
    "installations": [
      {
        "identity": "0x0413c6edddc476230c6c72ad579d21d9dee2311910186b638e6916a081d208554a7f6d167f22468ea7421accc9b5591c9d405730b4dc605106a68636ddecadfb2c",
        "id": "71ea6ce8-f30f-4501-9f8d-7801ab803a49",
        "version": 1,
        "enabled": true,
        "timestamp": 0, // this should not be 0
        "metadata": {
          "name": "local desktop 1",
          "deviceType": "macosx",
          "fcmToken": ""
        }
      }
    ],
    "notifications": null
  }
}
  1. Expected result:
{
  "type": "messages.new",
  "event": {
    "installations": [
      {
        "identity": "0x0413c6edddc476230c6c72ad579d21d9dee2311910186b638e6916a081d208554a7f6d167f22468ea7421accc9b5591c9d405730b4dc605106a68636ddecadfb2c",
        "id": "71ea6ce8-f30f-4501-9f8d-7801ab803a49",
        "version": 1,
        "enabled": true,
        "timestamp": 123, // some non-zero value
        "metadata": {
          "name": "local desktop 1",
          "deviceType": "macosx",
          "fcmToken": ""
        }
      }
    ],
    "notifications": null
  }
}

Acceptance Criteria

The event.installations[0].timestamp value should be greater than 0.

Notes

  1. The signal shown in "Actual result" is the same signal being seen on Device 1 (the device that initiated the advertisement).
  2. The 0 timestamp issue occurs the same when advertising from a status-desktop instance and from a status-react instance.

emizzle avatar Apr 23 '21 09:04 emizzle

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

status-github-bot[bot] avatar Aug 05 '21 15:08 status-github-bot[bot]