Database package location refactor

[Samyoul]

trafficstars

Problem

This repository has a number of database related packages that are spread out across the code base and I'm looking to consult with the team about consolidating them.

The other major problem with this implementation is that the business logic is too tightly coupled to the DB type and syntax with no layer of abstraction in between. This would make changing to another form of data persistence an involved task.

Packages I've identified are:

• appdatabase
• appdatabase/migrations
• db
• multiaccounts
• protocol/encryption/multidevice
• protocol/encryption/sharedsecret
• protocol/internal/sqlite
• protocol/transport/waku
• protocol/transport/whisper
• protocol/sqlite
• services/browsers
• services/mailservers
• services/permissions
• sqlite

Implementation

1. Discuss the roles of each of the identified packages, identify any additional packages that are database related.
2. Come to a consensus about the consolidation approach for the identified packages.
3. Move packages into the decided structure
4. Refactor all dependant packages

Acceptance Criteria

Database related packages are restructured as per the consensus arrived to here in this issue.

Notes

This isn't a witch hunt, or in any way a criticism of implementation choices made in the past, I'm certain every contributor that placed these packages where they are currently had legitimate reasons for doing so. The purpose of this issue is to get the code base into a state where it is more easily understood by a new developer (like me 😄 ), and consolidate related packages where it makes sense.

Future Steps

Any additional database based functionality should adhere to the conventions established here in this issue.

[Samyoul]

@cammellos FYI, what we were discussing earlier today.

[status-github-bot[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.