status-go icon indicating copy to clipboard operation
status-go copied to clipboard

Clarify which fields of `Message` should be filled in in `Messenger.SendChatMessage()`

Open adambabik opened this issue 5 years ago • 1 comments
trafficstars

Problem

Messenger.SendChatMessage() takes two arguments: context.Context and *Message. The latter is a very complex structure with a protobuf struct embedded. From the sender perspective, it's unclear which fields must be provided.

Implementation

Make it clear which fields are required by either (1) providing a separate method or (2) changing *Message to a simpler struct which will get merged with a new instance of Message within the method.

Acceptance Criteria

  1. It is clear which fields are required to send public, private and group messages.

adambabik avatar Jan 10 '20 13:01 adambabik

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

status-github-bot[bot] avatar Aug 05 '21 15:08 status-github-bot[bot]