status-go icon indicating copy to clipboard operation
status-go copied to clipboard

Move patch 0023 to services package

Open adambabik opened this issue 5 years ago • 1 comments
trafficstars

Problem

We have this patch https://github.com/status-im/go-ethereum/blob/patched/1.9/_assets/patches/0023-extract-personal-sign-api.patch. It only requires two methods EcRecover and Sign which can be easily extracted from geth's internal/ package.

Implementation

Create a new service in serivces/ or extend an existing one with EcRecover and Sign. Implementation should be taken from https://github.com/status-im/go-ethereum/blob/patched/1.9/internal/ethapi/api.go.

Acceptance Criteria

  1. The patch is gone but the API is available through an existing or new service.

adambabik avatar Jan 07 '20 20:01 adambabik

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

status-github-bot[bot] avatar Aug 05 '21 15:08 status-github-bot[bot]