status-go
status-go copied to clipboard
Makefile fails if GOPATH has multiple entries
Problem
make setup fails if there are multiple entries in the GOPATH environment variable.
Implementation
Maybe the first entry in GOPATH should be used in the Makefile, this is the approach go get uses.
Acceptance Criteria
status-go can be built with multiple entries in the GOPATH
@zachzundel how do such multiple entries look like? For example GOPATH=/one/path:/second/path etc?
Yes
On Mon, Dec 17, 2018 at 06:08 Adam Babik [email protected] wrote:
@zachzundel https://github.com/zachzundel how do such multiple entries look like? For example GOPATH=/one/path:/second/path etc?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/status-go/issues/1323#issuecomment-447839614, or mute the thread https://github.com/notifications/unsubscribe-auth/AC8zTViCbW8OwNV9gtsjjnrbcUgD_K68ks5u55dIgaJpZM4ZU9_O .
Ok, all clear. Thanks for reporting this issue! I marked it with a label for people who would like to contribute to the project for better visibility.
hey @zachzundel @adambabik,
I think I've fixed this in #1376 ? But just read CONTRIBUTE.md and closed it to comply with guidelines + goahead to work on this
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.