split block storage

[tersec]

[tersec]

2022-08-02T07:01:14.1824551Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/beacon_chain_db.nim: In function ‘getSplitBlock__beacon95chain95db_37951’:
2022-08-02T07:01:14.1826047Z /home/runner/work/nimbus-eth2/nimbus-eth2/beacon_chain/beacon_chain_db.nim:903:200: error: dereferencing pointer to incomplete type ‘tyObject_TrustedSignedPartialBeaconBlock__nZPmS9bKi6dcEhRUFGxsqgg {aka struct tyObject_TrustedSignedPartialBeaconBlock__nZPmS9bKi6dcEhRUFGxsqgg}’
2022-08-02T07:01:14.1826904Z    if GetResult.found != db.partialBlocks[T.toFork].getSZSSZ(
2022-08-02T07:01:14.1827349Z                                                                                                                                                                                                         ^                                                                               
2022-08-02T07:01:14.2158988Z make[1]: *** [/home/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/nimbus_light_client/@mbeacon_chain_db.nim.c.o] Error 1
2022-08-02T07:01:14.2164643Z nimcache/release/nimbus_light_client/nimbus_light_client.makefile:1547: recipe for target '/home/runner/work/nimbus-eth2/nimbus-eth2/nimcache/release/nimbus_light_client/@mbeacon_chain_db.nim.c.o' failed
2022-08-02T07:01:14.2167366Z make: *** [nimbus_light_client] Error 2
2022-08-02T07:01:14.2167872Z Makefile:333: recipe for target 'nimbus_light_client' failed

[github-actions[bot]]

Unit Test Results

       6 files   -        3     452 suites   - 226   12m 43s :stopwatch: - 11m 11s 1 997 tests +       1  1 848 :heavy_check_mark: +       1  149 :zzz: ±  0  0 :x: ±0  5 410 runs   - 2 704  5 256 :heavy_check_mark:  - 2 685  154 :zzz:  - 19  0 :x: ±0 

Results for commit cd255d9b. ± Comparison against base commit 1293e361.

:recycle: This comment has been updated with latest results.

[tersec]

https://github.com/nim-lang/Nim/issues/20141 is what hit the Linux CIs. They're using Ubuntu 18.04, and thus gcc 7.x, while the VM in which I recreated/tested this was Ubuntu 20.04 and gcc 9.x, so presumably it spans at least those versions of gcc.

[tersec]

Probably not worthwhile once enforcing MIN_EPOCHS_FOR_BLOCK_REQUESTS of around 5 months.