runme icon indicating copy to clipboard operation
runme copied to clipboard

Remove `languageId` from markdown cells

Open christian-bromann opened this issue 2 years ago • 2 comments

It seems that for markdown sections we return a languageId property that is always empty. I guess we can remove this?

christian-bromann avatar Dec 17 '22 03:12 christian-bromann

I was thinking about hiding it when it's empty but if I read TS correctly, NotebookCellData requires presence of languageId always.

adambabik avatar Dec 20 '22 11:12 adambabik

That is true, however it should not be a concern for the runme CLI as it should provide an ideal interface for what it is doing and not be too dependent on VS Code. In fact we don't even use/access the property. So there is not really a value to be 1:1 compliant with the VS Code API.

christian-bromann avatar Dec 21 '22 08:12 christian-bromann