SB-Admin-BS4-Angular-8 icon indicating copy to clipboard operation
SB-Admin-BS4-Angular-8 copied to clipboard

Published 20 hours ago • verified publisher icon start-angular

Karma test failures

Open shekhargulati opened this issue 8 years ago • 5 comments

I just checked out the code and ran karma tests. On my machine, 16 tests are failing. Is this is a known thing?

I have fixed all tests on my machine so I can raise PR if no one is working on it.

shekhargulati avatar Dec 05 '17 12:12 shekhargulati

Agree! 👍

fabiomartino avatar Dec 10 '17 12:12 fabiomartino

@shekhargulati Can you please raise a PR for this if you have already fixed the tests?

alpesh-patel93 avatar Jan 04 '18 11:01 alpesh-patel93

I haven't had time to dig into the failures yet, but after downloading the project this afternoon I can confirm that the latest master branch still has 16 failing tests.

nsideras avatar Feb 14 '18 20:02 nsideras

This issue arises every now and then. How do you see running the tests automatically on travis-ci or somewhere?

bjakubiak avatar Apr 27 '18 17:04 bjakubiak

Think I have fixed this here: https://github.com/start-angular/SB-Admin-BS4-Angular-6/pull/239

It also includes config to run it in CI (@bjakubiak good call), a collaborator/owner would just need to activate it in Travis CI.

TyGuy avatar Jun 24 '18 06:06 TyGuy