iOS-classic icon indicating copy to clipboard operation
iOS-classic copied to clipboard

Remove Alamofire dependency and use native networking library

Open moughxyz opened this issue 8 years ago • 8 comments

I'm beginning an effort to trim down dependencies cross platform in the name of longevity. There's an easy opportunity here to remove Alamofire and use NSURLSession or NSURLConnection.

moughxyz avatar Feb 27 '17 17:02 moughxyz

I'll start working on this I've been really busy lately. Not many contributions lately

jz709u avatar Mar 13 '17 08:03 jz709u

No worries, I think this one can be an easy win.

moughxyz avatar Mar 13 '17 15:03 moughxyz

@jz709u Have you started on this issue/help wanted? If not I would like to start contributing to the project by tackling this @mobitar.

JacobBoyd avatar May 31 '17 03:05 JacobBoyd

It's all yours! This would be a great improvement.

moughxyz avatar May 31 '17 03:05 moughxyz

The native networking methods can really be quite buggy. Sounds like a great improvement though. Would you like some help @JacobBoyd ?

flowinho avatar Jun 14 '17 07:06 flowinho

Sorry guys, I am starting the this issue now. I was kinda of busy for a while. I will keep this thread updated as I make progress!

JacobBoyd avatar Aug 19 '17 14:08 JacobBoyd

I have set up

GET(_ url: String, parameters: [String: Any], completionHandler: @escaping(_ response: Data) -> (), errorHandler: @escaping(_ error: Error) -> ())

and

POST(_ url: String, parameters: [String : Any], completionHandler: @escaping(_ response: Data) -> (), errorHandler: @escaping(_ error: Error)->()) -> Void

Methods for the new class StandardNotesURLSession. I am working on error handling and accepted http status codes. I am also planning to create a .download() for the class.

JacobBoyd avatar Aug 30 '17 02:08 JacobBoyd

Feel free to submit the pull request at any time, even if it's still a WIP. This way others can follow along.

I am also planning to create a .download() for the class.

How would that work?

moughxyz avatar Aug 30 '17 14:08 moughxyz