webadmin icon indicating copy to clipboard operation
webadmin copied to clipboard

semver: remove build number or version suffix

Open Bixilon opened this issue 9 months ago • 3 comments

See https://github.com/stalwartlabs/mail-server/pull/1256

Bixilon avatar Feb 26 '25 17:02 Bixilon

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 26 '25 17:02 CLAassistant

(After seeing the patch)

Idea: Add a without patch and with patch screenshot to make visible what this merge request improves.

Regards Geert Stappers (Somewhat worried about what happens when no build number is present.)

stappersg avatar May 04 '25 09:05 stappersg

@stappersg What? I don't get it. Is this an AI message?

There is no visual difference, it is just not crashing when appending -foss to the version name.

Bixilon avatar May 04 '25 16:05 Bixilon

See https://github.com/stalwartlabs/stalwart/pull/1256

https://github.com/stalwartlabs/stalwart/pull/1256 is closed, NOT merged.

For which reason is this merge request open? Not answering that question and just closing this mr will prevent further drain of human energy on it.

stappersg avatar Aug 13 '25 09:08 stappersg