Reloader icon indicating copy to clipboard operation
Reloader copied to clipboard

Reloader support for CronJobs

Open ksudarsh00 opened this issue 2 years ago • 5 comments

Description: Currently, reloader doesn't support CronJobs, so I have implemented support for Kubernetes CronJobs in the Stakater/Reloader repository and would like to contribute this feature back to the project.

Feature Implementation: I have extended the functionality of Reloader to include support for Kubernetes CronJobs. With this enhancement, Reloader can now detect changes in ConfigMaps/Secrets and perform triggering a Job from an existing CronJob definition.

Steps to Reproduce: To observe the added functionality, you can follow these steps:

Install Reloader in your Kubernetes cluster using the existing installation instructions.

Create a CronJob resource definition and add the annotations to watch for ConfigMaps/secrets.

Apply changes to the ConfigMap/Secrets resource such as modifying the data.

Verify that Reloader detects the changes and triggers a Job from the CronJob.

Code Contribution: I have made the necessary modifications to the Reloader codebase to enable support for Kubernetes CronJobs. The changes include additions to the Reloader's resource detection logic and the implementation of triggering a Job from an existing CronJob.

I have thoroughly tested the feature, which works as expected in my company's pre-production environment.

I would happily contribute the code changes I've made to the Stakater/Reloader repository and collaborate with the maintainers to ensure proper integration.

If you think this feature is lacking and it's in your roadmap. Please let me know how I can proceed with this contribution.

ksudarsh00 avatar May 22 '23 21:05 ksudarsh00

Yes definitely @ksudarsh00! PRs are more than welcome

rasheedamir avatar May 22 '23 21:05 rasheedamir

Looking forward to this feature as well!

kaiwalyajoshi avatar May 24 '23 23:05 kaiwalyajoshi

Amazing, exactly what I need. Is there any prediction of when they will merge this feature?

andreyolv avatar May 31 '23 12:05 andreyolv

Feature is available since #486

RockyMM avatar Oct 05 '23 17:10 RockyMM