error-stack-parser icon indicating copy to clipboard operation
error-stack-parser copied to clipboard

Add a failling test for node paths with parens

Open mattwynne opened this issue 4 years ago • 3 comments

Description

See https://github.com/stacktracejs/error-stack-parser/issues/62

This PR is just a failing test to reproduce the problem. I'm hoping it should help someone who's a newcomer to open source and wants to contribute a fix.

I expect we can close this PR without merging it when someone submits a better PR that includes a fix 😄

Motivation and Context

Failing test to reproduce https://github.com/stacktracejs/error-stack-parser/issues/62

How Has This Been Tested?

Added a new test case in spec/error-stack-parser-spec.js for this scenario.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] node_modules/.bin/jscs -c .jscsrc error-stack-parser.js passes without errors
  • [ ] npm test passes without errors
  • [x] I have read the contribution guidelines
  • [ ] I have updated the documentation accordingly
  • [x] I have added tests to cover my changes

mattwynne avatar Jul 19 '21 21:07 mattwynne

I don't know who needs to hear this but I have no node_modules/.bin/jscs in my local project. Is this step in the template out of date?

mattwynne avatar Jul 19 '21 21:07 mattwynne

If this is still an issue, can you resolve the conflict and ping me back once done?

niftylettuce avatar Feb 11 '22 17:02 niftylettuce

We ended up solving the problem by switching to stackchain so I've lost personal interest in this I'm afraid.

mattwynne avatar May 05 '22 20:05 mattwynne